Skip to content

Fix node breaker disconnect #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flo-dup wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix node breaker disconnect #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
477f3f7
Add failing unit tests
flo-dup Oct 16, 2023
bd9f2d5
Java 17 pattern variable
flo-dup Oct 16, 2023
11e97b5
Use the map in connectivityInspector
flo-dup Oct 16, 2023
c2ad2e0
Separate unit tests
flo-dup Oct 17, 2023
02b6741
Back to Edge instead of SwitchAttributes for equals collisions
flo-dup Oct 17, 2023
7954416
Connect bbs together for computing connectivity
flo-dup Oct 17, 2023
5c91608
Add unit test of disconnecting with line & 2wt
flo-dup Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 32 additions & 41 deletions network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/TerminalImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ private Resource<VoltageLevelAttributes> getVoltageLevelResource() {
private Set<Integer> getBusbarSectionNodes(Resource<VoltageLevelAttributes> voltageLevelResource) {
return index.getStoreClient().getVoltageLevelBusbarSections(index.getNetwork().getUuid(), index.getWorkingVariantNum(), voltageLevelResource.getId())
.stream().map(resource -> resource.getAttributes().getNode())
.collect(Collectors.toSet());
.collect(Collectors.toCollection(LinkedHashSet::new));
}

private static Graph<Integer, Edge> filterSwitches(Graph<Integer, Edge> graph, Predicate<SwitchAttributes> filter) {
Expand Down Expand Up @@ -242,63 +242,54 @@ private boolean disconnectNodeBreaker(Resource<VoltageLevelAttributes> voltageLe
// create a graph with only closed switches
Graph<Integer, Edge> graph = NodeBreakerTopology.INSTANCE.buildGraph(index, voltageLevelResource, false, true);
Set<Integer> busbarSectionNodes = getBusbarSectionNodes(voltageLevelResource);
Integer bbs0 = busbarSectionNodes.iterator().next();
for (Integer busbarSectionNode : busbarSectionNodes) {
graph.addEdge(bbs0, busbarSectionNode, new Edge(new InternalConnectionAttributes(bbs0, busbarSectionNode)));
}

// inspect connectivity of graph without its non fictitious breakers to check if disconnection is possible
Predicate<SwitchAttributes> isSwitchOpenable = switchAttributes -> switchAttributes.getKind() == SwitchKind.BREAKER && !switchAttributes.isFictitious() && !switchAttributes.isOpen();
ConnectivityInspector<Integer, Edge> connectivityInspector
= new ConnectivityInspector<>(filterSwitches(graph, isSwitchOpenable.negate()));
Graph<Integer, Edge> noOpenableSwitchGraph = filterSwitches(graph, isSwitchOpenable.negate());
ConnectivityInspector<Integer, Edge> connectivityInspector = new ConnectivityInspector<>(noOpenableSwitchGraph);

List<Set<Integer>> connectedSets = connectivityInspector.connectedSets();
if (connectedSets.size() == 1) {
// it means that terminal is connected to a busbar section through disconnectors only
// it means that terminal is connected to a busbar section through non-openable switches only
// so there is no way to disconnect the terminal
} else {
// build an aggregated graph where we only keep breakers
int aggregatedNodeCount = 0;
Graph<Integer, Edge> breakerOnlyGraph = new Pseudograph<>(Edge.class);
Map<Integer, Integer> nodeToAggregatedNode = new HashMap<>();

// build the graph between connected sets where the edges are openable switches
Graph<Set<Integer>, Edge> breakerOnlyGraph = new Pseudograph<>(Edge.class);
for (Set<Integer> connectedSet : connectedSets) {
breakerOnlyGraph.addVertex(aggregatedNodeCount);
for (int node : connectedSet) {
nodeToAggregatedNode.put(node, aggregatedNodeCount);
}
aggregatedNodeCount++;
breakerOnlyGraph.addVertex(connectedSet);
}
for (Edge edge : graph.edgeSet()) {
if (edge.getBiConnectable() instanceof SwitchAttributes) {
SwitchAttributes switchAttributes = (SwitchAttributes) edge.getBiConnectable();
if (isSwitchOpenable.test(switchAttributes)) {
int node1 = graph.getEdgeSource(edge);
int node2 = graph.getEdgeTarget(edge);
int aggregatedNode1 = nodeToAggregatedNode.get(node1);
int aggregatedNode2 = nodeToAggregatedNode.get(node2);
breakerOnlyGraph.addEdge(aggregatedNode1, aggregatedNode2, edge);
}
if (edge.getBiConnectable() instanceof SwitchAttributes switchAttributes && isSwitchOpenable.test(switchAttributes)) {
int node1 = graph.getEdgeSource(edge);
int node2 = graph.getEdgeTarget(edge);
Set<Integer> aggregatedNode1 = connectivityInspector.connectedSetOf(node1);
Set<Integer> aggregatedNode2 = connectivityInspector.connectedSetOf(node2);
breakerOnlyGraph.addEdge(aggregatedNode1, aggregatedNode2, edge);
}
}

Set<String> openedSwitches = new HashSet<>();
// find minimal cuts from terminal to each of the busbar section in the aggregated breaker only graph
// so that we can open the minimal number of breaker to disconnect the terminal
MinimumSTCutAlgorithm<Integer, Edge> minCutAlgo = new EdmondsKarpMFImpl<>(breakerOnlyGraph);
for (int busbarSectionNode : busbarSectionNodes) {
int aggregatedNode = nodeToAggregatedNode.get(getAttributes().getNode());
int busbarSectionAggregatedNode = nodeToAggregatedNode.get(busbarSectionNode);
// if that terminal is connected to a busbar section through disconnectors only or that terminal is a busbar section
// so there is no way to disconnect the terminal
if (aggregatedNode == busbarSectionAggregatedNode) {
continue;
}
minCutAlgo.calculateMinCut(aggregatedNode, busbarSectionAggregatedNode);
for (Edge edge : minCutAlgo.getCutEdges()) {
if (edge.getBiConnectable() instanceof SwitchAttributes) {
SwitchAttributes switchAttributes = (SwitchAttributes) edge.getBiConnectable();
switchAttributes.setOpen(true);
index.updateSwitchResource(switchAttributes.getResource());
openedSwitches.add(switchAttributes.getResource().getId());
done = true;
}
MinimumSTCutAlgorithm<Set<Integer>, Edge> minCutAlgo = new EdmondsKarpMFImpl<>(breakerOnlyGraph);
Set<Integer> aggregatedNode = connectivityInspector.connectedSetOf(getAttributes().getNode());
Set<Integer> busbarSectionAggregatedNode = connectivityInspector.connectedSetOf(bbs0);
// if that terminal is connected to a busbar section through disconnectors only or that terminal is a busbar section
// so there is no way to disconnect the terminal
if (aggregatedNode == busbarSectionAggregatedNode) {
return false;
}
minCutAlgo.calculateMinCut(aggregatedNode, busbarSectionAggregatedNode);
for (Edge edge : minCutAlgo.getCutEdges()) {
if (edge.getBiConnectable() instanceof SwitchAttributes switchAttributes) {
switchAttributes.setOpen(true);
index.updateSwitchResource(switchAttributes.getResource());
openedSwitches.add(switchAttributes.getResource().getId());
done = true;
}
}

Expand Down
Loading