Fix tap position when setting low tap position #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
EtienneLt
commented
Apr 28, 2025
...rk-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/AbstractTapChanger.java
Outdated
Show resolved
Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/PhaseTapChangerImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
antoinebhs
reviewed
Apr 30, 2025
...e-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/tck/SwitchSetRetainedTest.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Apr 30, 2025
...-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/TwoWindingsTransformerTest.java
Show resolved
Hide resolved
antoinebhs
reviewed
Apr 30, 2025
...-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/TwoWindingsTransformerTest.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Apr 30, 2025
...-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/TwoWindingsTransformerTest.java
Show resolved
Hide resolved
|
Update PR description |
rolnico
requested changes
Apr 30, 2025
...rk-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/AbstractTapChanger.java
Outdated
Show resolved
Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/PhaseTapChangerImpl.java
Outdated
Show resolved
Hide resolved
...e-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/tck/SwitchSetRetainedTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
rolnico
requested changes
May 5, 2025
...rk-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/AbstractTapChanger.java
Outdated
Show resolved
Hide resolved
...rk-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/AbstractTapChanger.java
Outdated
Show resolved
Hide resolved
...-impl/src/main/java/com/powsybl/network/store/iidm/impl/AbstractTapChangerStepsReplacer.java
Outdated
Show resolved
Hide resolved
...-impl/src/main/java/com/powsybl/network/store/iidm/impl/AbstractTapChangerStepsReplacer.java
Outdated
Show resolved
Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/PhaseTapChangerImpl.java
Outdated
Show resolved
Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/PhaseTapChangerImpl.java
Outdated
Show resolved
Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/RatioTapChangerImpl.java
Outdated
Show resolved
Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/RatioTapChangerImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
|
EtienneLt
changed the title
EtienneLt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
bug fix
What is the current behavior?
when the low tap position is set position is not managed
What is the new behavior (if this is a feature change)?
deplacing the position according to a new low tap position set
Does this PR introduce a breaking change or deprecate an API?