Add buffer to delete extensions #573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
7 tasks
antoinebhs
reviewed
Oct 17, 2025
network-store-client/src/main/java/com/powsybl/network/store/client/util/QuadriConsumer.java
Show resolved
Hide resolved
antoinebhs
reviewed
Oct 17, 2025
...-store-client/src/main/java/com/powsybl/network/store/client/BufferedNetworkStoreClient.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Oct 17, 2025
Comment on lines
649
to
655
| private static <D> void cloneExternalBuffer(NetworkCollectionIndex<ExternalAttributesCollectionBuffer<D>> buffer, UUID networkUuid, | ||
| int sourceVariantNum, int targetVariantNum) { | ||
| // clone resources from source variant collection | ||
| ExternalAttributesCollectionBuffer<D> clonedCollection = | ||
| new ExternalAttributesCollectionBuffer<>(buffer.getCollection(networkUuid, sourceVariantNum)); | ||
| buffer.addCollection(networkUuid, targetVariantNum, clonedCollection); | ||
| } |
Collaborator
There was a problem hiding this comment.
is it a deep clone, use the same mechanism as usual buffer (a clone method in the buffer class)
Collaborator
Author
There was a problem hiding this comment.
sonar prefers not
antoinebhs
reviewed
Oct 17, 2025
...tore-client/src/test/java/com/powsybl/network/store/client/CachedNetworkStoreClientTest.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Oct 17, 2025
...re-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/CachedNetworkStoreClient.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Oct 17, 2025
| private final QuadriConsumer<UUID, Integer, ResourceType, Map<String, T>> removeFct; | ||
|
|
||
| private final Map<ResourceType, Map<String, T>> removeResourcesIds = new HashMap<>(); | ||
| private final BiConsumer<Map<String, T>, Map<String, T>> addFct; |
Collaborator
There was a problem hiding this comment.
maybe it more of a mergeFct than a addFct?
Collaborator
Author
There was a problem hiding this comment.
it is more a putAll function isnt it ?
antoinebhs
reviewed
Oct 17, 2025
...rk-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NetworkStoreClient.java
Outdated
Show resolved
Hide resolved
Collaborator
|
I'm dubious on whether or not it works with the existing buffer implementation for identifiables as they are closely related.
Another case:
Another case:
Can you verify that all these cases work fine with your implementation? And think about other similar cases that could be tricky as the new buffer is very linked to CollectionBuffer |
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
extension are delete one by one
What is the new behavior (if this is a feature change)?
add a buffer to delete all extension in one flush
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
the method removeExtension now works with a map of identifiable ids by extension instead of one identifiable name and one extension name
Other informations
linked with powsybl/powsybl-network-store-server#146
#572 is needed before merging these one