Skip to content

Conversation

@EtienneLt
Copy link
Collaborator

@EtienneLt EtienneLt commented Nov 10, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
no

What kind of change does this PR introduce?
feature

What is the current behavior?
when checking limits on a line the network is loading every limitsgroup and when updating it gives every groups to the server then it recreates all of them. So it does several useless operation.

What is the new behavior (if this is a feature change)?
To prevent from recreating every groups if not needed (meaning they are not modified), the pr adds @JSONVIEW and two new attributes filters : BASIC and WITH_LIMITS.
when BASIC is selected all data except operational limits are given to the server
when WITH_LIMITS is selected it gives all data with the limits for the server
it is only implemented for lines and two windings transformers

Other information:
attibutes sv should be removed if it works well

Signed-off-by: Etienne LESOT <[email protected]>
@EtienneLt EtienneLt self-assigned this Nov 10, 2025
@EtienneLt EtienneLt requested a review from jonenst November 12, 2025 13:54
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.8% Coverage on New Code (required ≥ 80%)
10.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

updateResources.put(resource.getId(), new ResourceAndFilter<>(resource, attributeFilter));
} else {
// To update when new filter will be added to define how to merge 2 different filters
if (resourceAndFilter.getAttributeFilter() != null && attributeFilter == null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed != to == ?

Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
@EtienneLt EtienneLt requested a review from jonenst January 6, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants