Skip to content

Keep CSS rules static #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flo-dup merged 14 commits into from
Jun 5, 2025
Merged

Keep CSS rules static #179

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
316a068
Keep CSS rules static
quinarygio Mar 18, 2025
0e9aeff
Fix eslint warning
quinarygio Mar 18, 2025
bae36fb
Fix zoom levels style definition
quinarygio Mar 19, 2025
465dbcc
Fix eslint warning
quinarygio Mar 19, 2025
1db36a6
Remove enableLevelOfDetail
flo-dup Mar 21, 2025
dfa3f6e
Merge remote-tracking branch 'origin/main' into keep-css-rules-static
flo-dup Mar 21, 2025
eabe0c4
Document NetworkAreaDiagramViewer constructor parameters
quinarygio Mar 25, 2025
cb422ba
Fix eslint error
quinarygio Mar 25, 2025
8167227
Merge branch 'main' into keep-css-rules-static
flo-dup Mar 31, 2025
8467b91
Merge branch 'main' into keep-css-rules-static
flo-dup Apr 8, 2025
fb6534b
Merge branch 'main' into keep-css-rules-static
flo-dup Apr 11, 2025
9b0d320
Simplify zoom levels css style
quinarygio Apr 11, 2025
9731e07
Separated stylesheet for zoom level css classes
quinarygio Apr 28, 2025
e5bb43d
Merge branch 'main' into keep-css-rules-static
flo-dup Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions demo/src/diagram-viewers/add-diagrams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,6 @@ export const addNadToDemo = () => {
);
});

const enableLevelOfDetail: boolean =
new URLSearchParams(window.location.search).get('enableLevelOfDetail') === 'true';

fetch(NadSvgPegaseNetworkExample)
.then((response) => response.text())
.then((svgContent) => {
Expand All @@ -317,17 +314,12 @@ export const addNadToDemo = () => {
handleTextNodeMove,
handleNodeSelect,
true,
enableLevelOfDetail,
null,
true,
[0, 1000, 2200, 2500, 3000, 4000, 9000, 12000, 20000],
handleToggleNadHover,
handleRightClick,
true
);

svgContainerNadPegase?.insertAdjacentHTML(
'afterbegin',
`<p>enableLevelOfDetail=${enableLevelOfDetail}, <a href=".?enableLevelOfDetail=${!enableLevelOfDetail}">reload toggle enableLevelOfDetail</a></p>`
);
});
};

Expand Down
228 changes: 228 additions & 0 deletions demo/src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,234 @@ path.nad-arrow-in:not(.nad-state-in .nad-arrow-in) {
animation: node-under-blink 3s infinite;
}


.nad-zoom-0 .nad-disconnected .nad-edge-path {
stroke-dasharray: 10 10
}
.nad-zoom-0 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 3
}
.nad-zoom-0 :is(
.nad-edge-infos, .nad-label-box, .nad-text-edges,
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line,
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line,
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line,
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: block
}

.nad-zoom-1000 .nad-disconnected .nad-edge-path {
stroke-dasharray: 10 10
}
.nad-zoom-1000 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 0.25%
}
.nad-zoom-1000 :is(
.nad-edge-infos, .nad-label-box, .nad-text-edges,
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line,
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line,
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line,
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: block
}

.nad-zoom-2200 .nad-disconnected .nad-edge-path {
stroke-dasharray: 10 10
}
.nad-zoom-2200 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 0.25%
}
.nad-zoom-2200 .nad-edge-infos {
display: none
}
.nad-zoom-2200 :is(
.nad-label-box, .nad-text-edges,
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line,
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line,
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line,
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: block
}

.nad-zoom-2500 .nad-disconnected .nad-edge-path {
stroke-dasharray: 0.5% 0.5%
}
.nad-zoom-2500 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 0.25%
}
.nad-zoom-2500 .nad-edge-infos {
display: none
}
.nad-zoom-2500 :is(
.nad-label-box, .nad-text-edges,
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line,
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line,
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line,
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: block
}

.nad-zoom-3000 .nad-disconnected .nad-edge-path {
stroke-dasharray: 0.5% 0.5%
}
.nad-zoom-3000 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 0.25%
}
.nad-zoom-3000 :is(.nad-edge-infos, .nad-label-box, .nad-text-edges) {
display: none
}
.nad-zoom-3000 :is(
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line,
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line,
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line,
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: block
}

.nad-zoom-4000 .nad-disconnected .nad-edge-path {
stroke-dasharray: 0.5% 0.5%
}
.nad-zoom-4000 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 0.25%
}
.nad-zoom-4000 :is(
.nad-edge-infos, .nad-label-box, .nad-text-edges,
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line
) {
display: none
}
.nad-zoom-4000 :is(
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line,
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line,
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: block
}

.nad-zoom-9000 .nad-disconnected .nad-edge-path {
stroke-dasharray: 0.5% 0.5%
}
.nad-zoom-9000 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 0.25%
}
.nad-zoom-9000 :is(
.nad-edge-infos, .nad-label-box, .nad-text-edges,
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line,
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line
) {
display: none
}
.nad-zoom-9000 :is(
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line,
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: block
}

.nad-zoom-12000 .nad-disconnected .nad-edge-path {
stroke-dasharray: 0.5% 0.5%
}
.nad-zoom-12000 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 0.25%
}
.nad-zoom-12000 :is(
.nad-edge-infos, .nad-label-box, .nad-text-edges,
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line,
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line,
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line
) {
display: none
}
.nad-zoom-12000 :is(
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: block
}

.nad-zoom-20000 .nad-disconnected .nad-edge-path {
stroke-dasharray: 0.5% 0.5%
}
.nad-zoom-20000 :is(
.nad-branch-edges .nad-edge-path,
.nad-3wt-edges .nad-edge-path,
.nad-branch-edges .nad-winding,
.nad-3wt-nodes .nad-winding,
.nad-vl-nodes circle.nad-unknown-busnode) {
stroke-width: 0.25%
}
.nad-zoom-20000 :is(
.nad-edge-infos, .nad-label-box, .nad-text-edges,
.nad-vl0to30-0, .nad-vl0to30-1, .nad-vl0to30-2, .nad-vl0to30-3, .nad-vl0to30-4, .nad-vl0to30-5, .nad-vl0to30-6, .nad-vl0to30-7, .nad-vl0to30-8, .nad-vl0to30-line,
.nad-vl30to50-0, .nad-vl30to50-1, .nad-vl30to50-2, .nad-vl30to50-3, .nad-vl30to50-4, .nad-vl30to50-5, .nad-vl30to50-6, .nad-vl30to50-7, .nad-vl30to50-8, .nad-vl30to50-line,
.nad-vl50to70-0, .nad-vl50to70-1, .nad-vl50to70-2, .nad-vl50to70-3, .nad-vl50to70-4, .nad-vl50to70-5, .nad-vl50to70-6, .nad-vl50to70-7, .nad-vl50to70-8, .nad-vl50to70-line,
.nad-vl70to120-0, .nad-vl70to120-1, .nad-vl70to120-2, .nad-vl70to120-3, .nad-vl70to120-4, .nad-vl70to120-5, .nad-vl70to120-6, .nad-vl70to120-7, .nad-vl70to120-8, .nad-vl70to120-line,
.nad-vl120to180-0, .nad-vl120to180-1, .nad-vl120to180-2, .nad-vl120to180-3, .nad-vl120to180-4, .nad-vl120to180-5, .nad-vl120to180-6, .nad-vl120to180-7, .nad-vl120to180-8, .nad-vl120to180-line,
.nad-vl180to300-0, .nad-vl180to300-1, .nad-vl180to300-2, .nad-vl180to300-3, .nad-vl180to300-4, .nad-vl180to300-5, .nad-vl180to300-6, .nad-vl180to300-7, .nad-vl180to300-8, .nad-vl180to300-line
) {
display: none
}

@keyframes line-blink {
0%,
80%,
Expand Down
117 changes: 0 additions & 117 deletions src/components/network-area-diagram-viewer/dynamic-css-utils.ts
View file
Open in desktop
Copy link
Member

@Tristan-WorkGH Tristan-WorkGH Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the rules available to projects currently using them, not just in the demo.

Copy link
Member

@Tristan-WorkGH Tristan-WorkGH Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @flo-dup suggest, either as default that can be override or at least as importable rules or css.

Copy link
Contributor

@flo-dup flo-dup Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the first suggestion, in fact I don't think we should put any default CSS in the component. That would mean injecting some CSS? Then how would a webpage with two components work, there would be conflicts with the two CSS?

Instead as you said we could give one or several CSS examples. But to me it's not clear how we could include a CSS file in the release.

Another simpler way to do this would be to leave the examples in the demo, and just add in the next migration guide the CSS which corresponds to the previous default DEFAULT_DYNAMIC_CSS_RULES: CSS_RULE[]. Indeed it's just a matter of migration, isn't it?

Copy link
Member

@Tristan-WorkGH Tristan-WorkGH Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead as you said we could give one or several CSS examples. But to me it's not clear how we could include a CSS file in the release.

Another simpler way to do this would be to leave the examples in the demo, and just add in the next migration guide the CSS which corresponds to the previous default DEFAULT_DYNAMIC_CSS_RULES: CSS_RULE[]. Indeed it's just a matter of migration, isn't it?

Well ok.

This file was deleted.

Loading
Loading