Skip to content

Fix NPM scripts #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Fix NPM scripts #182

merged 2 commits into from
Mar 20, 2025

Conversation

Tristan-WorkGH
Copy link
Member

@Tristan-WorkGH Tristan-WorkGH commented Mar 19, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Enhance the scripts of NPM and the CI.

What is the current behavior?

  • the CI run the lint goal, but it is also run during the build --> run twice
  • the "tsc" step during the build was missing

What is the new behavior (if this is a feature change)?
The linter is run only one time in the CI and tsc is run during the build.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Nothing.

Other information:

Signed-off-by: Tristan Chuine <[email protected]>
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clashes with #181

@Tristan-WorkGH
Copy link
Member Author

Clashes with #181

oh, i will revert the CI part then

Signed-off-by: Tristan <[email protected]>
@Tristan-WorkGH Tristan-WorkGH requested a review from flo-dup March 20, 2025 10:55
@Tristan-WorkGH Tristan-WorkGH changed the title Fix CI & NPM scripts Fix NPM scripts Mar 20, 2025
@flo-dup flo-dup merged commit 81a731a into main Mar 20, 2025
6 checks passed
@flo-dup flo-dup deleted the enhance-scripts branch March 20, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants