Skip to content

Allow to bend parallels lines in NAD viewer#226

Draft
clementleclercRTE wants to merge 75 commits into
mainfrom
NAD-bending-lines
Draft

Allow to bend parallels lines in NAD viewer#226
clementleclercRTE wants to merge 75 commits into
mainfrom
NAD-bending-lines

Conversation

@clementleclercRTE

@clementleclercRTE clementleclercRTE commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

massimo-ferraro and others added 3 commits May 5, 2025 11:43
@massimo-ferraro
Allow to bend lines in NAD viewer
4d4f211 
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
@massimo-ferraro
Fix sonar issues
654bced 
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
@clementleclercRTE
implement bending feature
c1cdd2b 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE clementleclercRTE marked this pull request as draft September 16, 2025 09:34
@clementleclercRTE
fix redraw edge start on voltageLevel hover
e13f886 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
add bendline callback in demo
8b8464a 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
fix new point index
99379d4 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
prettier fix
77a55d8 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
add preview points functionality and replace index with data-index at…
a5fcf49 
…tribute

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
replace data-index attribute with WeakMap for line point index ma…
fab7527 
…nagement

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
eslint fix
f00f398 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
update edge metadata directly after create new point
94aa73a 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
replace WeakMap with Map for line point index management and clea…
21efe4b 
…r map on line bending disable

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
remove point addition when straightening
2a1d793 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
simplify bendable line check logic
01b76de 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge branch 'main' into NAD-bending-lines
e997c23 
# Conflicts:
#	demo/src/diagram-viewers/add-diagrams.ts
#	src/components/network-area-diagram-viewer/network-area-diagram-viewer.test.ts
#	src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
#	src/index.ts
@clementleclercRTE
merge main
d96d6a1 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
refactor code with getEdgeData function
5e5feab 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
fix sonar issues
06c1262 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
fix sonar issues
37b74ca 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge branch 'NAD-bending-lines' into nad_bend_lines
4a4d2c9 
# Conflicts:
#	demo/src/diagram-viewers/add-diagrams.ts
#	demo/src/diagram-viewers/data/nad-ieee9-zeroimpedance-cdf.svg
#	demo/src/diagram-viewers/data/nad-ieee9-zeroimpedance-cdf_metadata.json
#	src/components/network-area-diagram-viewer/diagram-utils.ts
#	src/components/network-area-diagram-viewer/network-area-diagram-viewer.test.ts
#	src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
#	src/index.ts
@clementleclercRTE
merge with "NAD_bending_line"
2d2f797 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
refactor linePointIndexMap to store edgeId and index
a0c7d3b 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
update diagram-utils.test to validate index and edgeId in `line…
27dd57d 
…PointMap`

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
add linePointByEdgeIndexMap to optimize line point element query an…
b42f06e 
…d updates

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge branch 'main' into NAD-bending-lines
ec5385b
@clementleclercRTE
add logic for parallel edge handling and offset calculation
ae69902 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
handle parallel bent line updates in metadata and redraw logic
ea70618 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
add support for parallel edge handling in redraw and bending logic
fd38af2 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
handle parallel straightening logic in metadata and redraw operations
0ae6ae8 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
refactor linePointIndexMap to use element IDs as keys and remove `l…
8c83eba 
…inePointByEdgeIndexMap`

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
replace ID-based queries with CSS classes
16fe061 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
replace ID-based selectors with CSS class selectors for edge preview …
3f20246 
…points

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge remote-tracking branch 'origin/main' into nad_bend_lines
d33b5a3
@clementleclercRTE
remove unused getEdgeId and getLinePointMapKey functions from `di…
904a4e1 
…agram-utils`

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
sonarqube fix
34f26f1 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
remove unused getLinePointId function from diagram-utils and repl…
0c6234d 
…ace its usage with `crypto.randomUUID`

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge remote-tracking branch 'origin/nad_bend_lines' into NAD-bending…
d8ae54c 
…-lines

# Conflicts:
#	src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
@clementleclercRTE
Implement parallel bend point calculation logic
ba169b8 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Refactor edge rendering and parallel bend logic to improve parallelis…
68f0748 
…m consistency and streamline edge preview point calculations.

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge remote-tracking branch 'origin/main' into NAD-bending-lines
4c17cb8 
# Conflicts:
#	demo/src/diagram-viewers/add-diagrams.ts
#	src/components/network-area-diagram-viewer/diagram-metadata.ts
#	src/components/network-area-diagram-viewer/diagram-utils.test.ts
#	src/components/network-area-diagram-viewer/diagram-utils.ts
#	src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
#	src/resources/material-icons/bend-lines.svg
@clementleclercRTE
Refactor edge rendering and bending logic to improve parallel group
94e374b 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Refactor bending logic and merge main
5cdbb94 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
test fix
1aea5dc 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Refactor getBendableLines to consider invisible edges
268ba2b 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Refactor edge direction calculation to handle grouped edges correctly.
cbd751e 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Add transformer shift logic to edge rendering
b43bea4 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Refactor midpoint calculation logic for forked edges and add `isConve…
54eeb94 
…rterStationEdge` utility function.

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge branch 'main' into NAD-bending-lines
c9e24e7
@clementleclercRTE
refactor and sonarCloud fix
bfecc88 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge remote-tracking branch 'origin/NAD-bending-lines' into NAD-bend…
3e1923b 
…ing-lines
@clementleclercRTE
Update getEdgePoints test cases to use object parameter syntax
148c4f6 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Refactor midpoint calculation
f738cce 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@sonarqubecloud

sonarqubecloud Bot commented Dec 1, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
8.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@clementleclercRTE
Merge branch 'main' into NAD-bending-lines
1ca44cc 
# Conflicts:
#	packages/network-viewer-core/src/network-area-diagram-viewer/network-area-diagram-viewer.ts
#	src/components/network-area-diagram-viewer/diagram-utils.test.ts
#	src/components/network-area-diagram-viewer/diagram-utils.ts
@clementleclercRTE
merge main branch and refactor.
a97a8ca 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Refactor midpoint calculation to simplify handling of forked and non-…
e1c3c24 
…forked edges.

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Adjust intersection tolerance to improve parallel line detection.
84b365a 
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>

Refactor midpoint calculation to simplify handling of forked and non-forked edges.

Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
@clementleclercRTE
Merge remote-tracking branch 'origin/NAD-bending-lines' into NAD-bend…
f090772 
…ing-lines
@sonarqubecloud

sonarqubecloud Bot commented Feb 16, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clementleclercRTE @massimo-ferraro @flo-dup