Adapt engine stopping criteria to test precision #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <[email protected]>
Hadrien-Godard
approved these changes
Mar 25, 2025
geofjamg
approved these changes
Mar 25, 2025
|
SylvestreSakti
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
A test fails in #1174 because the NR stopping criteria are larger thatn the epsilon used for result comparisons.
This test ensures stopping criteria are small enough so that the test is independent of the computation order.
What is the current behavior?
Test assertions not relevant because comparison precision is smaller than algorithm stopping criteria.
What is the new behavior (if this is a feature change)?
Test assertion precision consitent with algorithm stopping criteria. The tests is independant of the NR implementation.
Does this PR introduce a breaking change or deprecate an API?