-
Notifications
You must be signed in to change notification settings - Fork 8
Force area boundary branches to min impedance #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with the PR. If you find it useful, maybe a warning (or info) log can be added if there are zero impedance boundary branches with REPLACE_BY_ZERO_IMPEDANCE_LINE mode activated ?
src/test/java/com/powsybl/openloadflow/ac/AreaInterchangeControlTest.java
Show resolved
Hide resolved
Signed-off-by: vmouradian <[email protected]>
36dfc5a
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
If a Zero impedance branch is a boundary of an area, the AIC outerloop cannot compute interchange since P value of Zero impedance branches is not known until end of load flow and usage of ComputeZeroImpedanceFlows.
What is the new behavior (if this is a feature change)?
All boundary branches are forced to a minimum impedance, as for phase shifter controller.