Skip to content

Force area boundary branches to min impedance #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

vmouradian
Copy link
Member

@vmouradian vmouradian commented Apr 4, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

If a Zero impedance branch is a boundary of an area, the AIC outerloop cannot compute interchange since P value of Zero impedance branches is not known until end of load flow and usage of ComputeZeroImpedanceFlows.

What is the new behavior (if this is a feature change)?
All boundary branches are forced to a minimum impedance, as for phase shifter controller.

@vmouradian vmouradian requested a review from m-guibert April 4, 2025 12:15
jeandemanged
jeandemanged previously approved these changes Apr 11, 2025
@jeandemanged jeandemanged added the bug Something isn't working label Apr 11, 2025
SylvestreSakti
SylvestreSakti previously approved these changes Apr 11, 2025
Copy link
Contributor

@SylvestreSakti SylvestreSakti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the PR. If you find it useful, maybe a warning (or info) log can be added if there are zero impedance boundary branches with REPLACE_BY_ZERO_IMPEDANCE_LINE mode activated ?

Signed-off-by: vmouradian <[email protected]>
@vmouradian vmouradian dismissed stale reviews from SylvestreSakti and jeandemanged via 36dfc5a April 15, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants