Skip to content

Filter disabled generators when computing bus Q limits #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025

Conversation

vidaldid-rte
Copy link
Collaborator

@vidaldid-rte vidaldid-rte commented Apr 8, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
When a generator attached to a bus is disabled, exclude it from Q limit computations.

What is the current behavior?
Disabled generators are counted in Q limits.

What is the new behavior (if this is a feature change)?
Disabled generators are excluded from Q limits.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Didier Vidal <[email protected]>
@vidaldid-rte vidaldid-rte marked this pull request as draft April 8, 2025 09:57
Signed-off-by: Didier Vidal <[email protected]>
@vidaldid-rte vidaldid-rte marked this pull request as ready for review April 8, 2025 15:07
@@ -451,6 +451,7 @@ public double getMaxP() {

private double getLimitQ(ToDoubleFunction<LfGenerator> limitQ) {
return generators.stream()
.filter(g -> !g.isDisabled())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we apply the same filter for generationTargetP and generationTargetQ ?

Copy link
Collaborator Author

@vidaldid-rte vidaldid-rte Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, although if these quantities were wrong we would have noticed ...

Here is what happens (and it's not as homogeneous we would like... however some quantities can be cached, other not)

Here the protection is necessary because the disconnected groupe is removed from tension control and its targetQ might be added to the limit.

Fot generationTargetP, the mecanism is different. The contingency triggers a setTargetP to the group that invalidates the bus generationTargetP. So no need.

Slightly different for generationTargetQ - le quantity is directly updated by the contingence.

SylvestreSakti
SylvestreSakti previously approved these changes Apr 9, 2025
@jeandemanged jeandemanged changed the title Filter disabled groups when computing a bus Q limits Filter disabled generators when computing bus Q limits Apr 11, 2025
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged jeandemanged added the bug Something isn't working label Apr 11, 2025
@vidaldid-rte vidaldid-rte merged commit 814ae31 into main Apr 11, 2025
8 checks passed
@vidaldid-rte vidaldid-rte deleted the bug/exclude_disabled_gens_min_max_q branch April 11, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants