-
Notifications
You must be signed in to change notification settings - Fork 8
Filter disabled generators when computing bus Q limits #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
@@ -451,6 +451,7 @@ public double getMaxP() { | |||
|
|||
private double getLimitQ(ToDoubleFunction<LfGenerator> limitQ) { | |||
return generators.stream() | |||
.filter(g -> !g.isDisabled()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we apply the same filter for generationTargetP
and generationTargetQ
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, although if these quantities were wrong we would have noticed ...
Here is what happens (and it's not as homogeneous we would like... however some quantities can be cached, other not)
Here the protection is necessary because the disconnected groupe is removed from tension control and its targetQ might be added to the limit.
Fot generationTargetP, the mecanism is different. The contingency triggers a setTargetP to the group that invalidates the bus generationTargetP. So no need.
Slightly different for generationTargetQ - le quantity is directly updated by the contingence.
Signed-off-by: Damien Jeandemange <[email protected]>
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
When a generator attached to a bus is disabled, exclude it from Q limit computations.
What is the current behavior?
Disabled generators are counted in Q limits.
What is the new behavior (if this is a feature change)?
Disabled generators are excluded from Q limits.
Does this PR introduce a breaking change or deprecate an API?