Skip to content

[WIP] Force global 2P #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Force global 2P #1294

wants to merge 1 commit into from

Conversation

phiedw
Copy link
Collaborator

@phiedw phiedw commented Mar 5, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Code cleaning

What is the current behavior?

We allow to run a non global opt 2P (where we only reoptimize preventive remedial actions). This requires us to disable many actions (including preventive) for various reasons linking curative optimization to preventive. It also complicates the results structure a lot. And it gives worst results for little performance gain.

What is the new behavior (if this is a feature change)?
We now force global opt 2P, reoptimizing preventive actions and curative PSTs.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Users will have to remove the "re-optimize-curative-range-actions" field from parameters.

Other information:

Signed-off-by: Philippe Edwards <[email protected]>
@phiedw phiedw added cleaning This issue or pull request only concerns improving the overall state of the code breaking-change Changes could break users' code labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes could break users' code cleaning This issue or pull request only concerns improving the overall state of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant