Conversation
Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl1028.bureau.si.interne>
…t test Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl1028.bureau.si.interne>
Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl1028.bureau.si.interne>
…owsybl-open-rao into feat/range-action-type
Godelaine
reviewed
Mar 27, 2026
| @@ -0,0 +1,86 @@ | |||
| { | |||
| "$schema": "https://json-schema.org/draft/2020-12/schema#", | |||
| "$id": "resource:/schemas/hvdc-range-action/hvdc-range-action-v2.8.json", | |||
| if (value.getMax() < Integer.MAX_VALUE) { | ||
| gen.writeNumberField(JsonSerializationConstants.MAX, value.getMax()); | ||
| } | ||
| if (value.getRangeType() != RangeType.ABSOLUTE) { |
Collaborator
There was a problem hiding this comment.
pourquoi ne pas écrire ABSOLUTE systématiquement ?
Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl1028.bureau.si.interne>
Godelaine
requested changes
Mar 27, 2026
Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl1028.bureau.si.interne>
|
Godelaine
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently the range type can only be define for tap ranges
What is the new behavior (if this is a feature change)?
now definable for all ranges
Does this PR introduce a breaking change or deprecate an API?