Refacto: Replace manual parsing with XSD parsing for XML VirtualHubs configuration importer#1690
Open
vbochetRTE wants to merge 1 commit intomainfrom
Open
Refacto: Replace manual parsing with XSD parsing for XML VirtualHubs configuration importer#1690vbochetRTE wants to merge 1 commit intomainfrom
vbochetRTE wants to merge 1 commit intomainfrom
Conversation
…configuration importer Signed-off-by: Vincent BOCHET <vincent.bochet@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Refactoring
What is the current behavior?
In the current version of the code, XML VirtualHubs configuration files are imported through a manual parsing process: each element of the DOM is read as a generic node.
What is the new behavior (if this is a feature change)?
In the new version of the code, we use XSD file to generate Java classes that represent elements of the XML VirtualHubs configuration document. The content of the file is read and converted to specific Java objects.
This solution also provides more security as an input file that does not match the expected format will be rejected immediately.
Does this PR introduce a breaking change or deprecate an API?