You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check if the PR fulfills these requirements
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
A PR or issue has been opened in all impacted repositories (if any)
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
We add the possibility to use the CgmesDlImport import postprocessor.
The way the data imported is used by powsybl-diagram should be checked before allowing this
Does this PR introduce a breaking change or deprecate an API?
Yes
No
If yes, please check if the following requirements are fulfilled
The Breaking Change or Deprecated label has been added
The migration steps are described in the following section
What changes might users need to make in their application due to this PR? (migration steps)
too bad that it is not included in the next release. Do you have the wheel link for me from the dev build? The log is sadly expired. We've been waiting for the feature and I'd like to try it out.
too bad that it is not included in the next release. Do you have the wheel link for me from the dev build? The log is sadly expired. We've been waiting for the feature and I'd like to try it out.
This has been postponed because we realized that :
there is no way to access the imported data in pypowsybl for now (the extensions filled by the postprocessor are not mapped in python) and we did not have the time to do it now...
the diagram feature that uses the data from this postprocessor is actually broken currently, and must be fixed
Sorry for the extra wait time, when we have at least one of the two uses fixed it will be merged and testable using the daily snapshot wheels.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
We add the possibility to use the CgmesDlImport import postprocessor.
The way the data imported is used by powsybl-diagram should be checked before allowing this
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: