Add dynamic generator properties extensions #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gautier Bureau <[email protected]>
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Lisrte
force-pushed
the
tests_dynaswing
branch
from
ecd15aa to
e23502f
Compare
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
HugoKulesza
reviewed
Jan 7, 2026
Collaborator
HugoKulesza
left a comment
HugoKulesza
left a comment
There was a problem hiding this comment.
The code is OK, I think that it could be a good idea to precise in the ExtensionInformation that these are extensions to be used in dynamic simulation (and not used by all simulations)
Signed-off-by: lisrte <[email protected]>
|
|
Contributor
Author
Done |
HugoKulesza
approved these changes
Jan 8, 2026
github-project-automation
bot
moved this from In Progress
to Approved
in Release 03/2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
Handle powsybl-dynawo extensions:
Does this PR introduce a breaking change or deprecate an API?
Other information: