Skip to content

Add monitoring and full parameters mapping to Rao api #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

obrix
Copy link
Member

@obrix obrix commented Feb 28, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Fully map the rao parameters, and add mapping for rao result monitoring.

Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@obrix
Copy link
Member Author

obrix commented Feb 28, 2025

Still missing :

  • predefinedCombinations attribute of topo optimization parameters
  • add an already mapped sensitivity parameters instance in load flow and sensitivity parameters

@obrix obrix force-pushed the rao_monitoring_and_parameters branch 2 times, most recently from 9c98c64 to e88c133 Compare March 18, 2025 09:09
@obrix obrix changed the title [WIP] Add monitoring and full parameters mapping to Rao api Add monitoring and full parameters mapping to Rao api Mar 31, 2025
@obrix obrix requested a review from HugoKulesza March 31, 2025 07:20
@obrix obrix force-pushed the rao_monitoring_and_parameters branch from 681fdf6 to 6be5ca2 Compare March 31, 2025 12:50
@obrix obrix force-pushed the rao_monitoring_and_parameters branch from 2ee16e3 to 0f18527 Compare April 4, 2025 08:38
@obrix
Copy link
Member Author

obrix commented Apr 4, 2025

@HugoKulesza Following changes of rao version dependency, there is some rework to do on the mapping to handle the new RaoParameters. We are moving release target to 06/25.

@obrix obrix force-pushed the rao_monitoring_and_parameters branch from 0f18527 to 4b23686 Compare April 8, 2025 13:30
obrix added 2 commits April 8, 2025 16:05
Monitoring run wrapping.

Signed-off-by: Bertrand Rix <[email protected]>

Map ObjectiveFunctionParameters.

Signed-off-by: Bertrand Rix <[email protected]>

Fully map RaoParameters.

Signed-off-by: Bertrand Rix <[email protected]>

Update test.

Signed-off-by: Bertrand Rix <[email protected]>

Clean.

Signed-off-by: Bertrand Rix <[email protected]>

Clean.

Signed-off-by: Bertrand Rix <[email protected]>

Finish mapping angle monitoring.

Signed-off-by: Bertrand Rix <[email protected]>

Unsigned char instead of bool.

Signed-off-by: Bertrand Rix <[email protected]>

Try some explcit parameter setting.

Signed-off-by: Bertrand Rix <[email protected]>

more parameters

Signed-off-by: Bertrand Rix <[email protected]>

Introduce parameter base.

Signed-off-by: Bertrand Rix <[email protected]>

Support load flow and sensitivity parameters within rao parameters.

Signed-off-by: Bertrand Rix <[email protected]>

No pointer for base.

Signed-off-by: Bertrand Rix <[email protected]>

Correctly handle destruction of sensi parameters and rao parameters.

Signed-off-by: Bertrand Rix <[email protected]>

Clean.

Signed-off-by: Bertrand Rix <[email protected]>

Support predefined combinations parameters and correctly free rao parameters memory.

Signed-off-by: Bertrand Rix <[email protected]>

Clean monitoring api.

Signed-off-by: Bertrand Rix <[email protected]>

Fix type check.

Signed-off-by: Bertrand Rix <[email protected]>

Rename parameter base to provider parameters.

Signed-off-by: Bertrand Rix <[email protected]>

Rename attributes and function parameters.

Signed-off-by: Bertrand Rix <[email protected]>

Clean

Signed-off-by: Bertrand Rix <[email protected]>
@obrix obrix force-pushed the rao_monitoring_and_parameters branch from 4b23686 to 2110aa4 Compare April 8, 2025 14:05
…ngly define the artefact name.

Signed-off-by: Bertrand Rix <[email protected]>
Copy link

sonarqubecloud bot commented Apr 9, 2025

Copy link

sonarqubecloud bot commented Apr 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants