Skip to content

Add operator strategies and remedial actions from a JSON file #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 72 commits into
base: main
Choose a base branch
from
Open

Add operator strategies and remedial actions from a JSON file #978

wants to merge 72 commits into from

Conversation

nao1345678
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #954

@nao1345678 nao1345678 force-pushed the json-inputs-for-operator-strategies-and-actions branch from 2c8ccdc to 15be858 Compare April 3, 2025 08:49
Naledi EL CHEIKH added 28 commits April 10, 2025 12:58
[failed] added java and python impl for reading json contingency list…
bb6e8c3 
… function

Signed-off-by: Naledi EL CHEIKH <[email protected]>
new function for reading json files in contingency container impl
5332784 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix import
9014a4d 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
new add contingency from json file implementation
8cc01de 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix add contingency from json file implementation
a8ba55c 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fixed add contingency from json file implementation
4bf1689 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fixed add contingency from json file implementation
058e7d3 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fixed venv
759dc0e 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fixed error handling
4bc688b 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fixed error handling
c0c0d45 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fixed add contingency impl and error handling
2de47df 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix error in implementation
5a04d95 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix error in implementation
fdcb324 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix error in test for json contingencies
fdde7d4 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
update of add json contingencies function with error handling
6e312f7 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
update of add json contingencies function with error handling
00328dd 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix checkstyle violation
b22a043 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
test with objects.requirenonnull
2344c34 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
test with try catch path initializer
6b7b48a 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
test with try catch path initializer
599a5f7 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add test file contingencies.json
21b666d 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
deleted unused field
6939e17 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
deleted unused field
5fc4b63 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fixed python impl of add_contingency_from_json_file function
eeadfd4 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add python tests
c6cab0c 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
rewrite of the python impl of the add_contingency_from_json_file func…
a493ec8 
…tion

Signed-off-by: Naledi EL CHEIKH <[email protected]>
rewrite python tests
fbae2c7 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
successful test to add contingencies from json file
42177ab 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
geofjamg and others added 18 commits April 10, 2025 13:00
@geofjamg
Add DiscreteMeasurements extension dataframe (#975)
0718eb5 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@alicecaron
Add documentation about RAO beta implementation (#958)
8373d33 
Signed-off-by: CARON Alice <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@rolnico
Switch snapshot ci to new app and rework notification design (#938)
eaaae6a 
* rework CI snapshot
* add print
* fix jobs name
* format results
* change references from integration to snapshot

Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@CBiasuzzi
Adds more customization parameters to the NadProfile (#960)
bad6a9a 
Signed-off-by: Christian Biasuzzi <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@feldmarshall
Fix subscripts in per unit documentation (#962)
36dcb8c 
Signed-off-by: Michał Marszal <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@geofjamg @Lisrte
Update to PowSyBl dependencies 2025.0.0 (#974)
c6f1ffc 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Co-authored-by: lisrte <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@HugoKulesza
Adding terminals connection action (#953)
6d86170 
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@So-Fras
Add voltage_level_details parameter (#963)
8605861 
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@obrix
Fail early if crac is not valid (#979)
6e174c9 
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@CBiasuzzi
extends NadProfile with style customizations (#976)
8645d40 
Signed-off-by: Christian Biasuzzi <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@nao1345678
Add JSON file content to ContingencyContainer (#959)
84e46ab 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@HugoKulesza
Bump to v1.11.0
0019d17 
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@HugoKulesza
Bump to v1.12.0.dev1
0bf09d8 
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@HugoKulesza
fix upload of wheels (force upgrade packaging) (#981)
52fadb4 
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix syntax error
9bbad75 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
changed test files and python test
6a50f50 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
deleted tests for c functions
28e9ee9 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
deleted unused imports
b7a0dbd 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@nao1345678 nao1345678 force-pushed the json-inputs-for-operator-strategies-and-actions branch from c8ef044 to b7a0dbd Compare April 10, 2025 11:00
@nao1345678 nao1345678 changed the title [WIP] Add operator strategies and remedial actions from a JSON file Add operator strategies and remedial actions from a JSON file Apr 10, 2025
@nao1345678 nao1345678 requested a review from HugoKulesza April 10, 2025 11:07
HugoKulesza
HugoKulesza requested changes Apr 16, 2025
View reviewed changes
java/pypowsybl/src/test/java/com/powsybl/python/security/SecurityAnalysisTest.java Outdated
@@ -23,6 +23,7 @@
import org.assertj.core.data.Offset;
import org.junit.jupiter.api.Test;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is useful ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add these imports, and after a quick check they seem necessary.

.gitignore Outdated
Comment on lines 61 to 63

# Documentation generated files (autosummary)
docs/reference/api/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to remove this here

Naledi EL CHEIKH added 3 commits April 16, 2025 15:23
add files to gitignore
2873cbd 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
delete unused import
8b624c8 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
delete unused import
de83cb7 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'pypowsybl-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'pypowsybl'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nao1345678 nao1345678 self-assigned this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoKulesza HugoKulesza HugoKulesza requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@nao1345678 nao1345678

Labels
Release 06/2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run a security analysis with json files inputs for contingencies, operator strategies and remedial actions