Skip to content

set_sound_volume (Sound) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

set_sound_volume (Sound) #492

merged 1 commit into from
Mar 20, 2025

Conversation

JaskRendix
Copy link
Contributor

@JaskRendix JaskRendix commented Mar 19, 2025

PR introduces a new method set_sound_volume(sound_type, volume) which lets you change the volume of individual sound types after they've been loaded and to reduce code duplication, I've introduced a play_sound_type(sound_type) method (if it's fine, could you add it to the pygame-ce version too?).

@ppizarror
Copy link
Owner

Hi @JaskRendix, Thanks for this contribution. It all seems great and follows the library's code standards. Merging!

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.15%. Comparing base (7a200ac) to head (8d0226f).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
pygame_menu/sound.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files          49       49           
  Lines       12474    12485   +11     
=======================================
+ Hits        12119    12130   +11     
  Misses        355      355           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppizarror ppizarror merged commit 2f0cec4 into ppizarror:master Mar 20, 2025
11 of 12 checks passed
@JaskRendix JaskRendix deleted the patch-1 branch March 20, 2025 06:53
@JaskRendix
Copy link
Contributor Author

@ppizarror you're welcome, could you add it here (https://github.com/ppizarror/pygame-menu/tree/4.4.3-ce)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants