WIP: Enable AOT for osu!framework #5907
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NATIVE_DLL_SEARCH_DIRECTORIES` is not present on AOT runtimes.
`NATIVE_DLL_SEARCH_DIRECTORIES` is not present on AOT runtimes.
This requires a lot of reflection and/or dynamic code and is fundamentally incompatible with AOT as-is...: - Properties/metrhods of the current class: we can retain members of the current class with [DynamicallyAccessedMembers]. - Dynamic code generation (MakeGenericMethod): this one is much harder to because it's a generic method... Disabling for now because this fails to serialise to input.json and causes fatal errors.
Because JSON serialisation isn't working, it's saving empty files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a tracking PR so progress can be seen. This is separate from/unrelated to/not necessary for any Mono/iOS AOT efforts (@frenzibyte).
Fairly low priority.
Current state:
SampleGame.Desktopruns,osu.Framework.Testsruns without tests.