Skip to content

Fix second button click moving slider while dragging #6565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

Kruchji
Copy link
Contributor

@Kruchji Kruchji commented Apr 11, 2025

Fixes: ppy/osu#32765

@bdach
Copy link
Collaborator

bdach commented Apr 14, 2025

I appear to still be able to break this:

Screen.Recording.2025-04-14.at.09.38.30.mov
  1. Start dragging a slider bar that has a nub, but start the drag by clicking somewhere else than the nub
  2. Drag some
  3. Right click
  4. Move mouse further
  5. Nub will move away from where it should be

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@Kruchji
Copy link
Contributor Author

Kruchji commented Apr 14, 2025

Thanks for testing the behavior, I've hopefully fixed this case in the last commit. I've also included a second test for it - not sure if it's needed.

@bdach
Copy link
Collaborator

bdach commented Apr 16, 2025

Thanks, seems to work well now 👍

That said I did apply a few small adjustments on my own in 0ddfd87 and 6462479; please check them when able.

@bdach bdach merged commit 26d86a5 into ppy:master Apr 16, 2025
14 checks passed
@bdach bdach added the area:UI label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay playback speed bar doing weird moves
2 participants