Apply autosize continuously instead of relying on transforms #6566
+185
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
April 11, 2025 15:56
minetoblend
changed the title
minetoblend
changed the title
minetoblend
commented
Apr 11, 2025
| return; | ||
| } | ||
|
|
||
| Vector2 newSize = Interpolation.DampContinuously(baseSize, targetSize, duration / 4, Time.Elapsed); |
There was a problem hiding this comment.
The duration / 4 value is kind of eyeballed here, it will bring the current value within 0.4% of the target value after the given duration has passed. When testing this the resulting animation roughly landed in the right ballpark for most cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up/alternative to #6560 to explore another approach which applies the AutoSize animation continuously instead of relying on transforms.
I tried keeping the AutoSizeDuration property (partially because
FlowContainer.LayoutDirectionuses it) but the actual duration will only roughly match the specified amount now given that the actual time taken depends on how big the change was.Perhaps exposing this as a parameter with a more explicit name (i.e.
AutoSizeDamping/Decay) would be a better choice here.