Add Bopomofo characters#368
Merged
Merged
Conversation
Font does not contain 100% all glyphs, but it's the closest thus far.
1 task
peppy
approved these changes
Jun 25, 2025
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was initially going to refresh the entirety of the CJK character set as it's been about 8 years since the font was first added, but the right font variant to contain all of the glyphs in Basic and Compatibility has long since vanished and some glyphs have been lost. Nowadays, Google offers
Noto Sans JP,Noto Sans SC, andNoto Sans TC. The JP version doesn't contain most of the glyphs in the Compatibility font, and is more bold compared to the ones in the assets. The SC version however seems to do the job but still lacks a few glyphs here and there.It was deemed best to just add the Bopomofo character set separately and not touch the existing CJK assets. However, I've repurposed the configuration file to match the glyphs actually contained in the Basic and Compatibility font binaries, as the original configuration file contains much more than that (even latin glyphs). I've also changed the font in the configuration file to
Noto Sans SCas it is the one with (mostly) all glyphs required (JP doesn't contain most glyphs in compatibility, as mentioned previously).I've also bundled a configuration file dedicated to the Bopomofo character set, and I've included few extra characters that are part of the Bopomofo set and which wasn't included in ppy/osu#25845 (comment). I don't think there's a problem with including them.
@peppy generated assets are pending trimming and optimisation, figured I would leave that part to you as you're most familiar with this.