Skip to content

Comments

Add extended playlist management capabilities to referee hub#434

Open
bdach wants to merge 4 commits intoppy:masterfrom
bdach:referee-playlist-mgmt
Open

Add extended playlist management capabilities to referee hub#434
bdach wants to merge 4 commits intoppy:masterfrom
bdach:referee-playlist-mgmt

Conversation

@bdach
Copy link
Collaborator

@bdach bdach commented Feb 20, 2026

Namely adding / editing / removing playlist items other than the current one.

Of particular note:

  • PlaylistItemChanged event receives (via its new superclass) an Order field so that clients can know which orders the items are to be played.
  • I've applied concessions in StandardMatchController wherein all referees have host-level control over the playlist (all referees can add items even if the room is host-only, and all referees can remove items that they don't own). This isn't particularly relevant yet but will be in the next changes (which will permit multiple referees in one room).
  • 775d1d7 is a small reorder because in testing I've noticed that with the previous call order clients would briefly see ushort.MaxValue in the playlist order field. It is rectified by a later edit event for the same playlist item, so it wouldn't have caused a real issue, but it just felt wrong to keep. (Notably, writing this referee API and looking at how many events are dispatched, we can probably do better in reducing the number of events dispatched because some appear redundant. But that can wait for another day.)

Everything else in the diff is largely trite boilerplate.

Tested via own PoC client (bdach/osu-referee-client-poc@e1317fe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

1 participant