Add extended playlist management capabilities to referee hub#434
Open
bdach wants to merge 4 commits intoppy:masterfrom
Open
Add extended playlist management capabilities to referee hub#434bdach wants to merge 4 commits intoppy:masterfrom
bdach wants to merge 4 commits intoppy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namely adding / editing / removing playlist items other than the current one.
Of particular note:
PlaylistItemChangedevent receives (via its new superclass) anOrderfield so that clients can know which orders the items are to be played.StandardMatchControllerwherein all referees have host-level control over the playlist (all referees can add items even if the room is host-only, and all referees can remove items that they don't own). This isn't particularly relevant yet but will be in the next changes (which will permit multiple referees in one room).ushort.MaxValuein the playlist order field. It is rectified by a later edit event for the same playlist item, so it wouldn't have caused a real issue, but it just felt wrong to keep. (Notably, writing this referee API and looking at how many events are dispatched, we can probably do better in reducing the number of events dispatched because some appear redundant. But that can wait for another day.)Everything else in the diff is largely trite boilerplate.
Tested via own PoC client (bdach/osu-referee-client-poc@e1317fe).