Skip to content

Update packages#303

Merged
peppy merged 6 commits intoppy:masterfrom
peppy:update-packages
Mar 17, 2026
Merged

Update packages#303
peppy merged 6 commits intoppy:masterfrom
peppy:update-packages

Conversation

@peppy
Copy link
Copy Markdown
Member

@peppy peppy commented Mar 16, 2026

Initial pass, the parameter names I changed were all weird, plus with the new version of CommandLineUtils case sensitivity seems to no longer be a thing, causing errors in overlapping param names.

I think we should just use the long form on all cases.

Schedule(() =>
{
if (userPanel != null)
userPanel?.Data.Value = new UserCardData
Copy link
Copy Markdown
Contributor

@smoogipoo smoogipoo Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately will need to update InspectCode because this is a recent C# language goodie

Edit: Or set <LangVersion>12.0</LangVersion> in the csproj, same as we use in osu: https://github.com/ppy/osu/blob/73644d87bc747be4cfc00fe5f2f1a44910ba3e3d/Directory.Build.props#L4-L5

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like it yet. undone for now..

@peppy peppy force-pushed the update-packages branch from 94ba34e to ea0a3bd Compare March 16, 2026 05:51
@smoogipoo
Copy link
Copy Markdown
Contributor

The error we're intending to resolve here is the Automapper vulnerability, right? It's a transitive dependency from the osu! project, shall I wait on merging this until it's updated there?

@peppy
Copy link
Copy Markdown
Member Author

peppy commented Mar 16, 2026

The error we're intending to resolve here is the Automapper vulnerability, right? It's a transitive dependency from the osu! project, shall I wait on merging this until it's updated there?

can wait if you want, or get this in first and i'll do that separately.

i'm attempting to get nunit up to date too while i'm there, so it may take a touch longer.

As defined in `osu.Tools.props`. No need to override/define this here.
@stanriders stanriders added perfcalc-gui PerformanceCalculatorGUI perfcalc-cli PerformanceCalculator labels Mar 16, 2026
@peppy peppy merged commit b471efb into ppy:master Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perfcalc-cli PerformanceCalculator perfcalc-gui PerformanceCalculatorGUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants