Update packages#303
Conversation
| Schedule(() => | ||
| { | ||
| if (userPanel != null) | ||
| userPanel?.Data.Value = new UserCardData |
There was a problem hiding this comment.
Unfortunately will need to update InspectCode because this is a recent C# language goodie
Edit: Or set <LangVersion>12.0</LangVersion> in the csproj, same as we use in osu: https://github.com/ppy/osu/blob/73644d87bc747be4cfc00fe5f2f1a44910ba3e3d/Directory.Build.props#L4-L5
There was a problem hiding this comment.
I'm not sure I like it yet. undone for now..
|
The error we're intending to resolve here is the Automapper vulnerability, right? It's a transitive dependency from the osu! project, shall I wait on merging this until it's updated there? |
can wait if you want, or get this in first and i'll do that separately. i'm attempting to get nunit up to date too while i'm there, so it may take a touch longer. |
As defined in `osu.Tools.props`. No need to override/define this here.
Initial pass, the parameter names I changed were all weird, plus with the new version of
CommandLineUtilscase sensitivity seems to no longer be a thing, causing errors in overlapping param names.I think we should just use the long form on all cases.