Skip to content

Add first place scores to Profile screen #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peppy merged 2 commits into from
Mar 25, 2026
Merged

Add first place scores to Profile screen #306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1611ed0
Add first place scores to Profile screen
stanriders Mar 24, 2026
4339f81
InspectCode
stanriders Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions PerformanceCalculatorGUI/Screens/ProfileScreen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public partial class ProfileScreen : PerformanceCalculatorScreen

private StatefulButton calculationButton = null!;
private SwitchButton includePinnedCheckbox = null!;
private SwitchButton includeFirstsCheckbox = null!;
private SwitchButton onlyDisplayBestCheckbox = null!;
private VerboseLoadingLayer loadingLayer = null!;

Expand Down Expand Up @@ -183,6 +184,20 @@ private void load()
UseFullGlyphHeight = false,
Text = "Include pinned scores"
},
includeFirstsCheckbox = new SwitchButton
{
Anchor = Anchor.CentreLeft,
Origin = Anchor.CentreLeft,
Current = { Value = false },
},
new OsuSpriteText
{
Anchor = Anchor.CentreLeft,
Origin = Anchor.CentreLeft,
Font = OsuFont.Torus.With(weight: FontWeight.SemiBold, size: 14),
UseFullGlyphHeight = false,
Text = "Include first place scores"
},
onlyDisplayBestCheckbox = new SwitchButton
{
Anchor = Anchor.CentreLeft,
Expand Down Expand Up @@ -233,8 +248,6 @@ private void load()

usernameTextBox.OnCommit += (_, _) => { calculateProfiles(usernameTextBox.Current.Value.Split(",", StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)); };
sorting.ValueChanged += e => { updateSorting(e.NewValue); };
includePinnedCheckbox.Current.ValueChanged += e => { calculateProfiles(currentUsers); };
onlyDisplayBestCheckbox.Current.ValueChanged += e => { calculateProfiles(currentUsers); };

if (RuntimeInfo.IsDesktop)
HotReloadCallbackReceiver.CompilationFinished += _ => Schedule(() => { calculateProfiles(currentUsers); });
Expand Down Expand Up @@ -313,6 +326,13 @@ private void calculateProfiles(string[] usernames)
apiScores = apiScores.Concat(pinnedScores.Where(p => apiScores.All(b => b.ID != p.ID)).ToArray()).ToList();
}

if (includeFirstsCheckbox.Current.Value)
{
var firstScores = await apiManager.GetJsonFromApi<List<SoloScoreInfo>>($"users/{player.OnlineID}/scores/firsts?mode={ruleset.Value.ShortName}&limit={max_api_scores_in_one_query}")
.ConfigureAwait(false);
apiScores = apiScores.Concat(firstScores.Where(p => apiScores.All(b => b.ID != p.ID)).ToArray()).ToList();
}

foreach (var score in apiScores)
{
if (token.IsCancellationRequested)
Expand Down
Loading