Show legacy forum icons on topic listing, posts, and post search#11277
Show legacy forum icons on topic listing, posts, and post search#11277cl8n wants to merge 7 commits intoppy:masterfrom
Conversation
| $table->mediumIncrements('icons_id'); | ||
| $table->string('icons_url')->default(''); | ||
| $table->tinyInteger('icons_width')->default(0); | ||
| $table->tinyInteger('icons_height')->default(0); | ||
| $table->unsignedMediumInteger('icons_order')->default(0); | ||
| $table->boolean('display_on_posting')->default(true); | ||
|
|
||
| $table->index(['display_on_posting'], 'display_on_posting'); |
There was a problem hiding this comment.
could use a double-check for accuracy bc I just copied thsi from phpbb3.0
nanaya
left a comment
nanaya
left a comment
There was a problem hiding this comment.
also the icons are very ugly especially with dark background. I wonder if the non-essentials should just be removed
| use App\Traits\Memoizes; | ||
| use Illuminate\Database\Eloquent\Collection; | ||
|
|
||
| class ForumLegacyIcons |
There was a problem hiding this comment.
It doesn't seem it's used frequently enough to warrant this (and all the usage seems involve querying the post/topic)
| <img | ||
| alt="" | ||
| class="forum-legacy-icon" | ||
| src="{{ osu_url('forum_legacy_icons') }}/{{ $icon->icons_url }}" |
There was a problem hiding this comment.
the url generation should be the icon's method
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| .forum-legacy-icon { | ||
| margin: 0 5px; |
There was a problem hiding this comment.
I think this can use gap on __icons instead
| <img class="search-forum-post__avatar-image" src="{{ $user->user_avatar }}"> | ||
| </a> | ||
|
|
||
| @if ($post->legacyIcon() !== null) |
There was a problem hiding this comment.
I don't think this is a good place to put the icon. It just looks wrong
There was a problem hiding this comment.
Icons should go before or after the title, or in the information lines at the bottom, imo. It should definitely not be shifting the layout of entire blocks.
3 participants
resolves #2814
it's pretty ugly with most icons but I hope that can be forgiven since it's just a historical thing.