put header-nav-v4 in front of blurred menu image#11817
Open
WebFreak001 wants to merge 1 commit intoppy:masterfrom
Open
put header-nav-v4 in front of blurred menu image#11817WebFreak001 wants to merge 1 commit intoppy:masterfrom
WebFreak001 wants to merge 1 commit intoppy:masterfrom
Conversation
ensures the colors pop more and avoids legibility issues with certainly colored menu images
Member
|
I'm on board with this change visually 👍 |
Collaborator
|
it's inconsistent with the the below the image though. If anything I'd rather just remove the extended highlight or reduce its size (or some other adjustments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
z-index: 1to thedashboard friends watchlists account settingsmenu at the top on the start page, so it's in front of the blurred background image that is currently on top of the menu.This makes the colors pop more as well as making the border color consistent on the active item as well as just the rest of the bar.
Before:
After:
Artificial purple image
The effect is most notable when the menu image has a lot of dark purple / areas of color close to the menu bar color (example using an image of just a solid purple block):
Before:
After:
Artificial white image
However it might not look as good with very light / white headers: (border color now matches the big blob though)
Before:
After: