Add "osu! original" beatmap badge and search filter#12634
Open
Hiviexd wants to merge 4 commits intoppy:masterfrom
Open
Add "osu! original" beatmap badge and search filter#12634Hiviexd wants to merge 4 commits intoppy:masterfrom
Hiviexd wants to merge 4 commits intoppy:masterfrom
Conversation
LiquidPL
approved these changes
Dec 31, 2025
|
Not sure if this is also necessary but what if you add osu! originals button next to Featured Artist button as shown on the screenshot below
Maybe its easier for players to try to find their favorite osu! original song |
Hiviexd
changed the title
nanaya
requested changes
Jan 5, 2026
| 'title' => $beatmapset->title, | ||
| 'title_unicode' => $beatmapset->title_unicode, | ||
| 'track_id' => $beatmapset->track_id, | ||
| 'is_exclusive_track' => $beatmapset->track?->exclusive ?? false, |
Collaborator
There was a problem hiding this comment.
this just can't be here as it'll cause one additional query for each beatmapset
| private function addExclusiveTracksFilter($query) | ||
| { | ||
| if ($this->params->showExclusiveTracks) { | ||
| $trackIds = ArtistTrack::where('exclusive', true)->pluck('id'); |
Collaborator
There was a problem hiding this comment.
maybe add another field to the es index instead of passing hundreds of id every time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9864.
The osu! original badge is prioritized over the FA one in terms of rendering because it'd be redundant given all original tracks are FA, alongside the limited beatmap card space.
Also made the explicit badge link to its relevant wiki page.