Purge beatmap audio preview cache when updating #12841
Merged
peppy merged 6 commits intoppy:masterfrom Mar 13, 2026
Merged
Conversation
- remove transitional system support (custom method and url) - use guzzle instead of stream context for simpler api
nanaya
force-pushed
the
audio-preview-purge
branch
from
e118ec5 to
d39b987
Compare
nanaya
force-pushed
the
audio-preview-purge
branch
from
d39b987 to
09ef58a
Compare
notbakaneko
previously approved these changes
Mar 12, 2026
nanaya
dismissed
notbakaneko’s stale review
The merge-base changed after approval.
peppy
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes change to
preview_urlvalue to include the scheme. The client isn't currently using the field so it should be fine-ish to change (to be adjusted in ppy/osu#36945).