-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated "Cookie" article #12966
base: master
Are you sure you want to change the base?
Updated "Cookie" article #12966
Conversation
Thank you for contributing to the osu! wiki. Please take note of the following:
See the contribution guide for more information. All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 👍
More things I would like to address:
- It might look better if the logos are all the same size
doneslightly similar to
is redundant in my opinion because the users can compare the logos on their own- Does it say somewhere who made each logo? Would appreciate if we can include this info
- I think it would be nice to include a reference to the "the dot" topic, like so:
| [...] only used shortly due to criticism.[^logo-with-dot] |
[...]
## Notes
[^logo-with-dot]: [Reddit post by bartwalker (2024-25-01) "The full new osu!lazer logo (as on github), what do you think?"](https://www.reddit.com/r/osugame/comments/19faqqf/the_full_new_osulazer_logo_as_on_github_what_do/)
Other resource as an alternative: the new osu! logo is worse than you think...
- Does someone have the missing logos at hand perhaps? Here is a site listing several logos, however, no guarantee for anything.
wiki/Client/Interface/Cookie/en.md
Outdated
| Cookie | Years used | Notes | | ||
| :-: | :-: | :-- | | ||
|*missing*|2007 - 2011|Uses *Verdana*.| | ||
||2011 - 2014|Uses *Verdana*, slightly similar to 2007-2011 logo.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
||2011 - 2014|Uses *Verdana*, slightly similar to 2007-2011 logo.| | |
|  | 2011 - 2014 | Uses *Verdana*, slightly similar to 2007-2011 logo. | |
wiki/Client/Interface/Cookie/en.md
Outdated
|*missing*|2007 - 2011|Uses *Verdana*.| | ||
||2011 - 2014|Uses *Verdana*, slightly similar to 2007-2011 logo.| | ||
|*missing*|2014 - 2016|Uses *Aller*.| | ||
||2016 - present|Uses *Aller*, slightly similar to 2014-2016 logo.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
||2016 - present|Uses *Aller*, slightly similar to 2014-2016 logo.| | |
|  | 2016 - present | Uses *Aller*, slightly similar to 2014-2016 logo. | |
wiki/Client/Interface/Cookie/en.md
Outdated
|*missing*|2014 - 2016|Uses *Aller*.| | ||
||2016 - present|Uses *Aller*, slightly similar to 2014-2016 logo.| | ||
||January 2024 - May 2024|Uses *Torus*, only used shortly due to criticism.| | ||
||May 2024 - present|Uses *Torus*, similar to Jan 2024-May 2024 logo.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
||May 2024 - present|Uses *Torus*, similar to Jan 2024-May 2024 logo.| | |
|  | May 2024 - present | Uses *Torus*, similar to Jan 2024-May 2024 logo. | |
|
||
The following is a table that shows all of the cookies used all throughout the history of osu!. These have been put here for archival purposes. | ||
|
||
| Cookie | Years used | Notes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Cookie | Years used | Notes | | |
| Cookie | Year | Notes | |
Have you seen my other suggestions? Spaces in table cells are required as per the formatting guidelines. If you want, you can also work on the ideas described in my main review comment above. By the way, merging the base branch is not required as of now. This will be done upon approval of this PR. |
fixed it btw, also thanks |
added history
removed logo3 as it is missing
Co-authored-by: The-Last-Cookie <[email protected]>
Co-authored-by: The-Last-Cookie <[email protected]>
Co-authored-by: The-Last-Cookie <[email protected]>
Co-authored-by: The-Last-Cookie <[email protected]>
fixed a few stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To outdate translations, mark them with the tags outdated_translation: true
and outdated_since
, where the latter carries the hash value of the first commit in your PR.
Co-authored-by: The-Last-Cookie <[email protected]>
Co-authored-by: The-Last-Cookie <[email protected]>
Co-authored-by: The-Last-Cookie <[email protected]>
Co-authored-by: The-Last-Cookie <[email protected]>
Co-authored-by: The-Last-Cookie <[email protected]>
Co-authored-by: The-Last-Cookie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do these black squares come from? could you please use logos in PNG formats that support transparency and uphold image quality?
| *missing* | 2014 - 2016 | Uses *Aller*. | | ||
|  | 2016 - present | Uses *Aller* | | ||
|  | January 2024 - May 2024 | Uses *Torus*, only used shortly due to criticism. | | ||
|  | May 2024 - present | Uses *Torus*, used in [osu!(lazer)](/wiki/Help_centre/Upgrading_to_lazer) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used in osu!(lazer)
do you mean that the cookie is used, or the font? I'd suggest rephrasing this as "Can be seen in osu!(lazer)" for clarity
additionally, it would be cool to have more info as TheLastCookie mentioned above, but if you don't feel like digging for it, we can just get this over with once you update the cookies |
i usually see every file as jpeg, so i did such |
This PR modifies the article "Cookie", which is a sub-article of "Interface", which itself is also a sub-article of "Client".
This PR isn't checked by any reviewer and has only modified the English language variant, so BEWARE.
Self-check