Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "Cookie" article #12966

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Updated "Cookie" article #12966

wants to merge 21 commits into from

Conversation

mdlcgithub
Copy link

@mdlcgithub mdlcgithub commented Mar 15, 2025

This PR modifies the article "Cookie", which is a sub-article of "Interface", which itself is also a sub-article of "Client".

  • The notable change is the addition of a history for the osu! cookie.

This PR isn't checked by any reviewer and has only modified the English language variant, so BEWARE.

Self-check

Copy link

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

Copy link
Contributor

@The-Last-Cookie The-Last-Cookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍

More things I would like to address:

  1. It might look better if the logos are all the same size
  2. slightly similar to is redundant in my opinion because the users can compare the logos on their own done
  3. Does it say somewhere who made each logo? Would appreciate if we can include this info
  4. I think it would be nice to include a reference to the "the dot" topic, like so:
| [...] only used shortly due to criticism.[^logo-with-dot] |

[...]

## Notes

[^logo-with-dot]: [Reddit post by bartwalker (2024-25-01) "The full new osu!lazer logo (as on github), what do you think?"](https://www.reddit.com/r/osugame/comments/19faqqf/the_full_new_osulazer_logo_as_on_github_what_do/)

Other resource as an alternative: the new osu! logo is worse than you think...

  1. Does someone have the missing logos at hand perhaps? Here is a site listing several logos, however, no guarantee for anything.

| Cookie | Years used | Notes |
| :-: | :-: | :-- |
|*missing*|2007 - 2011|Uses *Verdana*.|
|![2011 - 2014](img/logo2.jpg)|2011 - 2014|Uses *Verdana*, slightly similar to 2007-2011 logo.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|![2011 - 2014](img/logo2.jpg)|2011 - 2014|Uses *Verdana*, slightly similar to 2007-2011 logo.|
| ![2011 - 2014](img/logo2.jpg) | 2011 - 2014 | Uses *Verdana*, slightly similar to 2007-2011 logo. |

|*missing*|2007 - 2011|Uses *Verdana*.|
|![2011 - 2014](img/logo2.jpg)|2011 - 2014|Uses *Verdana*, slightly similar to 2007-2011 logo.|
|*missing*|2014 - 2016|Uses *Aller*.|
|![2016 - present](img/logo4.jpg)|2016 - present|Uses *Aller*, slightly similar to 2014-2016 logo.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|![2016 - present](img/logo4.jpg)|2016 - present|Uses *Aller*, slightly similar to 2014-2016 logo.|
| ![2016 - present](img/logo4.jpg) | 2016 - present | Uses *Aller*, slightly similar to 2014-2016 logo. |

|*missing*|2014 - 2016|Uses *Aller*.|
|![2016 - present](img/logo4.jpg)|2016 - present|Uses *Aller*, slightly similar to 2014-2016 logo.|
|![January 2024 - May 2024](img/logo5.jpg)|January 2024 - May 2024|Uses *Torus*, only used shortly due to criticism.|
|![May 2024 - present](img/logo6.jpg)|May 2024 - present|Uses *Torus*, similar to Jan 2024-May 2024 logo.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|![May 2024 - present](img/logo6.jpg)|May 2024 - present|Uses *Torus*, similar to Jan 2024-May 2024 logo.|
| ![May 2024 - present](img/logo6.jpg) | May 2024 - present | Uses *Torus*, similar to Jan 2024-May 2024 logo. |


The following is a table that shows all of the cookies used all throughout the history of osu!. These have been put here for archival purposes.

| Cookie | Years used | Notes |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Cookie | Years used | Notes |
| Cookie | Year | Notes |

@The-Last-Cookie
Copy link
Contributor

Have you seen my other suggestions? Spaces in table cells are required as per the formatting guidelines.

If you want, you can also work on the ideas described in my main review comment above.

By the way, merging the base branch is not required as of now. This will be done upon approval of this PR.

@mdlcgithub
Copy link
Author

Have you seen my other suggestions? Spaces in table cells are required as per the formatting guidelines.

If you want, you can also work on the ideas described in my main review comment above.

By the way, merging the base branch is not required as of now. This will be done upon approval of this PR.

fixed it btw, also thanks

Copy link
Contributor

@The-Last-Cookie The-Last-Cookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To outdate translations, mark them with the tags outdated_translation: true and outdated_since, where the latter carries the hash value of the first commit in your PR.

@The-Last-Cookie
Copy link
Contributor

The-Last-Cookie commented Mar 25, 2025

This logo was used in the GitHub repo (osu!lazer) for quite a while, though I'm not sure in which time span.

lazer_small_icon

@mdlcgithub
Copy link
Author

This logo was used in the GitHub repo (osu!lazer) for quite a while, though I'm not sure in which time span.

lazer_small_icon

i might plan to add it by separating osu!stable and osu!lazer

Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do these black squares come from? could you please use logos in PNG formats that support transparency and uphold image quality?

| *missing* | 2014 - 2016 | Uses *Aller*. |
| ![2016 - present](img/logo4.jpg) | 2016 - present | Uses *Aller* |
| ![January 2024 - May 2024](img/logo5.jpg) | January 2024 - May 2024 | Uses *Torus*, only used shortly due to criticism. |
| ![May 2024 - present](img/logo6.jpg) | May 2024 - present | Uses *Torus*, used in [osu!(lazer)](/wiki/Help_centre/Upgrading_to_lazer) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in osu!(lazer)

do you mean that the cookie is used, or the font? I'd suggest rephrasing this as "Can be seen in osu!(lazer)" for clarity

@TicClick
Copy link
Contributor

additionally, it would be cool to have more info as TheLastCookie mentioned above, but if you don't feel like digging for it, we can just get this over with once you update the cookies

@mdlcgithub
Copy link
Author

where do these black squares come from? could you please use logos in PNG formats that support transparency and uphold image quality?

i usually see every file as jpeg, so i did such

@TicClick
Copy link
Contributor

i usually see every file as jpeg, so i did such

a good heuristic is that shapes with well-defined contours, small details, or detailed gradients require PNG

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants