-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add o!mLN4 Tournament Wiki page.
#13867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
MChecaH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First part of the review, up to Mappool format
RushFTK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply reviews from MChecaH
Co-authored-by: MChecaH <[email protected]>
Co-authored-by: MChecaH <[email protected]>
MChecaH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second part of the review
wiki/Tournaments/o!mLN/4/en.md
Outdated
|
|
||
| 1. **Any** rank players from **any** region can register this tournament. | ||
| 2. You must fill [Player Signup form](https://docs.google.com/forms/u/0/d/e/1FAIpQLSfQGnO66J7b22TgVmCTjhbmc3nyCpheLAup4wlMupt_3MUwcw/) to finish register. | ||
| 3. If player passed [tournament screening](/wiki/Tournaments/Official_support#tournament-screening) after register, they are able to play qualifiers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar + really weird phrasing.
| 3. If player passed [tournament screening](/wiki/Tournaments/Official_support#tournament-screening) after register, they are able to play qualifiers. | |
| 3. After registering, players **must** pass [tournament screening](/wiki/Tournaments/Official_support#tournament-screening) in order to be able to play Qualifiers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Poly's suggestion one, it's very thankful if you wanna do double check ><
wiki/Tournaments/o!mLN/4/en.md
Outdated
|
|
||
| #### Qualifiers | ||
|
|
||
| 1. After the screening phase has concluded, players eligible to play will participate in tournament play. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this point is needed. This is already implied in the third point of the Registrations section. Moreover, the second part of this sentence is redundant. It's somewhat obvious that only those eligible to play will be allowed to play in the tournament (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but just make sure the context orgainzed in order, since some people only read parts of rule documents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, if that's the case then the redundancy should be taken out of the third point and better explained here on the first one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied (remove this point)
wiki/Tournaments/o!mLN/4/en.md
Outdated
| #### Qualifiers | ||
|
|
||
| 1. After the screening phase has concluded, players eligible to play will participate in tournament play. | ||
| 2. In the first weekend, players will play 7 qualifiers maps in sequence up to 2 times, in a scheduled lobby (they may choose not to play the 2nd time if desired). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 2. In the first weekend, players will play 7 qualifiers maps in sequence up to 2 times, in a scheduled lobby (they may choose not to play the 2nd time if desired). | |
| 2. During the first weekend, players will play 7 Qualifiers in sequence up to 2 times in a scheduled lobby. Players may choose not to play the 2nd time if desired. |
|
I will waiting poly's review before make any changes, in case conflict happens. |
Updated prize pools, staff list, and external links to YouTube VOD Channel Slight grammar fixes
Update en.md
Applied Alll reviews from @MChecaH in o!mLN4 wiki page Co-authored-by: MChecaH <[email protected]>
MChecaH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small miscellaneous suggestions after the latest update.
| | Sheeter / Statistician | ::{ flag=US }:: [EpsilonMaiagare](https://osu.ppy.sh/users/3855052), ::{ flag=CN }:: [Yuiesta](https://osu.ppy.sh/users/13953619) | | ||
| | Developer | ::{ flag=KR }:: [Nopekjk](https://osu.ppy.sh/users/4585186), ::{ flag=KR }:: [yhsphd](https://osu.ppy.sh/users/6665667) | | ||
| | GFX Designer | ::{ flag=CN }:: [AlexDunk](https://osu.ppy.sh/users/9194799), ::{ flag=US }:: [Boolmaster Flex](https://osu.ppy.sh/users/5394681), ::{ flag=JP }:: [CrewK](https://osu.ppy.sh/users/11488604), ::{ flag=ID }:: [EndKun / Xion*](https://vgen.co/Xion2405), ::{ flag=MY }:: [Iyouka](https://osu.ppy.sh/users/7138499), ::{ flag=SE }:: [Melancholicc](https://osu.ppy.sh/users/18406374), ::{ flag=CN }:: [hourius](https://osu.ppy.sh/users/12580298), ::{ flag=IT }:: [MightyMigz](https://osu.ppy.sh/users/8863387), ::{ flag=ID }:: [nayuu](https://osu.ppy.sh/users/12561379), ::{ flag=PH }:: [Normiplier](https://osu.ppy.sh/users/10069850), ::{ flag=PH }:: [OsuMe65](https://osu.ppy.sh/users/852867), ::{ flag=SG }:: [Polytetral](https://osu.ppy.sh/users/8612061), ::{ flag=NL }:: [Promachos](https://osu.ppy.sh/users/14069486), ::{ flag=CN }:: [RiceSS](https://osu.ppy.sh/users/8271436), ::{ flag=CN }:: [Rush_FTK](https://osu.ppy.sh/users/3046856), ::{ flag=CN }:: [Sakura006](https://osu.ppy.sh/users/10365024), ::{ flag=CN }:: [Secondoverthree](https://osu.ppy.sh/users/13432062), ::{ flag=PH }:: [SPEC*](https://vgen.co/its_spec), ::{ flag=PH }:: [Swarmsii](https://osu.ppy.sh/users/11716111), ::{ flag=SG }:: [TheFunk](https://osu.ppy.sh/users/13981991), ::{ flag=HK }:: [Transendium](https://transendium.carrd.co/), ::{ flag=PH }:: [yukina meng](https://osu.ppy.sh/users/9919550), ::{ flag=MY }:: [xxxxxx2800](https://osu.ppy.sh/users/4084853), ::{ flag=MY }:: [Z419](https://osu.ppy.sh/users/9912966) | | ||
| | Composer | ::{ flag=CN }:: [Supa7onyz](https://osu.ppy.sh/u/5378805), ::{ flag=AU }:: [G4TE-16*](https://soundcloud.com/gate_16), ::{ flag=TH }:: [HowToPlayLN](https://osu.ppy.sh/users/10879600), ::{ flag=SG }:: [Hundotte*](https://www.youtube.com/c/hundotte), ::{ flag=US }:: [Ludicin](https://osu.ppy.sh/u/8659666), ::{ flag=US }:: [nm-y](https://osu.ppy.sh/u/31725557), ::{ flag=TH }:: [ohm002](https://osu.ppy.sh/u/4468239), ::{ flag=TH }:: [ptar124](https://osu.ppy.sh/u/4325444), ::{ flag=MY }:: [takehirotei](https://osu.ppy.sh/users/11793794), ::{ flag=PH }:: [THE BEAT WIZARD](https://osu.ppy.sh/u/17529207), ::{ flag=VN }:: [trung-nova](https://osu.ppy.sh/u/14927934), ::{ flag=SG }:: [sugosugiii](https://osu.ppy.sh/u/15118952), ::{ flag=SG }:: [SiLiS / Raveille](https://osu.ppy.sh/u/1388767), ::{ flag=SG }:: [XH*](https://xhdidwhat.carrd/) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All user links should be linked as /users/{user-id}. Not with /u/{user-id}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i haven't check poly's edit so far thanks for double checking, i'm still reviewing last reviews one by one to see if they are successfully to applied, i will check later ^^
Co-authored-by: MChecaH <[email protected]>
Walavouchey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remaining stuff
- past tense everywhere except ruleset (because tournament is over)
- add badge images
- sentence case in staff table
- participants missing
- podium missing
- match results missing
- ci errors (
/u/->/users/)
Self-check