-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add osu!taiko hits (don and katu) #13949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Walavouchey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
terminology needs a bit of discussion, reviewing wording later
SisypheOvO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think things can be better in order to make this a smooth article.
|
Yes, but not in this PR. They will be part of a separate article.
I was hoping to be able to provide an article which is thorough enough to not require this. If a maintainer thinks this is required, they may add it before merging.
|
|
Thanks! I hope these helped. Meta part just an example, stub isn't a need to add 😭 sorry for the ambiguity. |
Related to #3152
Edit: You may want to rename the article's folder to
Don_and_katif the PR is approved.Self-check