Add a link to reload the error page on wiki overlay #31376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloneWith
changed the title
bdach
requested changes
Feb 24, 2025
osu.Game/Overlays/WikiOverlay.cs
Outdated
Comment on lines
183
to
184
| $"{WikiOverlayStrings.PageErrorDescription(originalPath)}\n\n" | ||
| + $"{WikiOverlayStrings.ReloadPageLink(originalPath)}\n{WikiOverlayStrings.ReturnToMainPageLink(INDEX_PATH)}")); |
There was a problem hiding this comment.
You can't interpolate localisable strings like this. It defeats the entire point of localisable strings as they get ToString()ed if you do it like this. Use LocaisableString.Format() or LocalisableString.Interpolate() instead.
There was a problem hiding this comment.
WikiArticlePage doesn't support markdown input with LocalisableString, making it unable to display localised error content.
An possible solution is to use a TextFlowContainer or something like this, but I think it's going too far with this PR and needs some discussion. I'll complete the format part here.
|
Merge conflicts here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the errors encountered in the wiki overlay are about poor network and request timeout. So we may want to reload the current page when an error page is displayed.
At the same time I noticed that when changing the in-game language while we are on the error page, the overlay would stick to
errorpage because of the set value ofpath. In this PR I use a variable to store the path of the last available (request succeeded) page, with which we can bring users back.