Always end first chunk SectionLengthms after the first difficulty object
#32138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!diffcalc |
tsunyoku
moved this from In Progress
to Pending Review
in Difficulty calculation changes
|
!diffcalc |
|
!diffcalc |
|
!diffcalc |
|
Difficulty calculation queued -- please wait! (https://github.com/ppy/osu/actions/runs/14691614447) This comment will update on completion |
|
Difficulty calculation queued -- please wait! (https://github.com/ppy/osu/actions/runs/14691615243) This comment will update on completion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC.
This change ensures the first chunk always starts where the first object begins, preventing an existing scenario where the offset of a beatmap can increase or decrease star rating as it may shift what chunks objects end up in.
This isn't a stellar fix for chunking in general, and will cause what appears to be random increases or decreases depending on how ""optimised"" a beatmap's offset is with this current flaw.
Note this unintentionally affects all rulesets since this is defined in the general
StrainSkill. If this is decided as a way-to-go for the osu ruleset, then I will consult with the other PP committees to see if this logic should be moved to only affect the osu ruleset.