Add "strict timing" option to Relax mod #32487
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "strict timing" option to the Relax mod, which removes all timing leniency.
The Relax mod is the most obvious way to train one's aim, and many new players end up playing it assuming it will improve their non-RX aim. However, normal RX is generally far too lenient to suit that purpose, because aiming very early or late, which would result in misses in normal gameplay, isn't penalized at all in RX. This option fixes that problem, making RX an actually viable way to practice aim.
Unfortunately, strict timing is completely broken in replays when the replayer is running at a different framerate than the player. This is because frames where judgements are forced are not necessarily saved as important in the replay recorder (thanks peppy for pointing that out), but I have no clue how to fix this.
I also didn't write any tests for this, because I don't know if it makes sense to write tests that rely on replay frames when the mod option doesn't work in replays.