Award slider accuracy PP for scores set with ScoreV2

[Finadoggie]

This does not affect ranked play whatsoever. However, if sorting leaderboards by pp is implemented, this will affect local leaderboards with imported sv2 scores. Also (probably) impacts any community-made tournament pp calculators.

tl;dr this change doesn't have much reach but the performance impact is one if statement so I see no reason not to have it

[Finadoggie]

meant to target pp-dev, not master

[BunnyTub]

The Classic mod should still be carried in my opinion, as slider head accuracy and slider functionality differ. ScoreV2 on stable attempts to scale all hit object scoring values to a hard limit of 1 million at 1.00 Score Multiplier (excluding bonus spinner values in osu!, dendens in osu!taiko, and collected bananas in osu!catch). Taken that part from the wiki. It means that while the scoring methods are similar, they aren't the same, even with the score cap, if that makes sense.

[tsunyoku]

Sure

[stanriders]

I'm personally not against it, but it also is pretty much just code bloat - imported sv2 scores aren't really important in any way at all, and accounting for them (especially since the difference would be like 20pp at most) sounds kinda useless

[BunnyTub]

Wouldn't call it code bloat, since it does actually matter for score and pp calculation.

[stanriders]

It doesn't affect a single ranked or even lazer-first score, it'd only matter for imported from stable scorev2 scores which are super rare to begin with

[Finadoggie]

it'd only matter for imported from stable scorev2 scores which are super rare to begin with

Within the vacuum of the osu client, this is true. However, the pp calculator gets used by others for stuff like tournaments for stuff like tracking tournament pp records, and has even been referenced by commentators in official tournaments.

There should be an official standard for handling scores like this properly, rather than just pretending they’re normal classic scores.