-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Bring all new song select components together #32854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i don't know if it's right place to report, but scroll area for beatmap carousel is kinda far away on lower ui scalling, compare to current song select 1745311603_JarvYYYOQh.mp41745311903_ItScac8yCA.mp4 |
It's a valid concern. I'll add a mention in #32736. |
25cfbb1
to
c1a6e98
Compare
This intentionally removes shear specification from root level of `BeatmapTitleWedge` since shearing is moved one level higher (see fill flow containing `BeatmapTitleWedge` in `SongSelect`).
c1a6e98
to
c2a7687
Compare
@frenzibyte please check on this one to make sure nothing's out of order. |
peppy
previously approved these changes
Apr 30, 2025
Looks correct. |
c1af2d0
to
c2a7687
Compare
peppy
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike in #32715, all functionality implemented to
SongSelect
has not been pushed here, as it increased the review overhead magnificently.Below diff can be applied to test out song select with said functionality:
diff
Preview:
CleanShot.2025-04-18.at.08.48.16-converted.mp4