-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Bring all new song select components together #32854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frenzibyte
wants to merge
41
commits into
ppy:master
Choose a base branch
from
frenzibyte:song-select-v2-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and apply minor adjustments
…-v2-wedges-metadata
Used for range sliders
Copied logic from `BeatmapLeaderboard`.
This intentionally removes shear specification from root level of `BeatmapTitleWedge` since shearing is moved one level higher (see fill flow containing `BeatmapTitleWedge` in `SongSelect`).
i don't know if it's right place to report, but scroll area for beatmap carousel is kinda far away on lower ui scalling, compare to current song select 1745311603_JarvYYYOQh.mp41745311903_ItScac8yCA.mp4 |
It's a valid concern. I'll add a mention in #32736. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike in #32715, all functionality implemented to
SongSelect
has not been pushed here, as it increased the review overhead magnificently.Below diff can be applied to test out song select with said functionality:
diff
Preview:
CleanShot.2025-04-18.at.08.48.16-converted.mp4