Convert gameplay leaderboard to skinnable component #32939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations As time goes on, default skin layouts are getting more and more complicated because of per-ruleset overrides. This was already sort of apparent in ppy#31527, and I'm about to make it worse, so before I do, this is a test scene that is supposed to make it easier to check all possible combinations at a glance.
This PR converts the leaderboard into a full-fledged skinnable component that can be manipulated by users at will. Notably, this finally allows ppy#20422 to be fixed - although it's a very mixed bag, for several reasons: - Because of taiko players' refusal to see reason^W^W^W^Winsistence on keeping stable behaviours related to aspect ratio treatment, I have to assume the worst case scenario, which means than on typical resolutions like 16:9 (or even worse, 4:3), the leaderboard will likely not occupy as much vertical space as it probably could. - Additionally, there's the problem of where to put the spectator list. I settled on putting it to the right of the leaderboard, but that's kind of janky, because the leaderboard sometimes collapses and sometimes fully hides, leading to a very awkward space left behind. If we had the capability to anchor elements to other elements, maybe this could be resolved, but for now, I'm not sure what to do. I think if some users are bothered by it they can move it where they want it. Or delete it.
bdach
added
notable feature
bdach
commented
Apr 24, 2025
There was a problem hiding this comment.
Depending on whether we want to offer a "legacy" variant of the leaderboard matching stable skins, it might be a good idea to rename this component to something like ArgonGameplayLeaderboard before it gets persisted to the JSONs.
There was a problem hiding this comment.
I'm fine with either. We already have a good flow for migrating component names so it's not a huge deal.
| @@ -71,10 +70,7 @@ private void load() | |||
|
|
|||
| ScoreProcessor.ApplyNewJudgementsWhenFailed = true; | |||
|
|
|||
| LoadComponentAsync(new GameplayChatDisplay(Room) | |||
| { | |||
| Expanded = { BindTarget = LeaderboardExpandedState }, | |||
There was a problem hiding this comment.
This being coupled to leaderboard expansion state is a bit of a spoke in the wheel. I simplified this to just use LocalUserPlaying which is one half of what was steering the expansion state. Maybe fine?
bdach
commented
Apr 24, 2025
| leaderboard.Anchor = Anchor.BottomLeft; | ||
| leaderboard.Origin = Anchor.BottomLeft; | ||
| leaderboard.Position = pos; | ||
| leaderboard.Height = 170; |
There was a problem hiding this comment.
This height can be improved later when the positioning of taiko combo counter is adjusted to match stable (should be on the drum).
- Naming wasn't adjusted - When the chat collapsed, the team score display broke due to zero width Partial revert of ppy@da1fc10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the leaderboard a full skinnable component (placed in the ruleset-specific layer).
Users with skins that have custom HUD layouts need to add the gameplay leaderboard back themselves in their desired position.
This change also allows the leaderboard to stop overlapping the playfield in taiko.
This PR converts the leaderboard into a full-fledged skinnable component that can be manipulated by users at will.
Notably, this finally allows #20422 to be fixed - although it's a very mixed bag, for several reasons:
refusal to see reasoninsistence on keeping stable behaviours related to aspect ratio treatment, I have to assume the worst case scenario, which means than on typical resolutions like 16:9 (or even worse, 4:3), the leaderboard will likely not occupy as much vertical space as it probably could.As with the spectator list, if some users have modified the layout on their skin, they will not have the leaderboard added back, and I'm not trying to add any migrations to try and do it for them.
Recommend reviewing with whitespace off.