Collection: show missing count when beatmaps are deleted (#32244) #32944
Conversation
Intended to closes ppy#32244
SkyheartOfficial
changed the title
| ? $"{count:#,0} item" | ||
| : $"{count:#,0} items"; | ||
| // subscribe to all BeatmapInfo changes | ||
| subscription = realmAccess.RegisterForNotifications( |
There was a problem hiding this comment.
So this, in total, is going to take out as many subscriptions as there are collections in this list? That's going to be a very difficult one to accept for me. People have a lot of collections.
| { | ||
| List<string> beatmapHashes = collection.PerformRead(c => c.BeatmapMD5Hashes.ToList()); | ||
| int total = beatmapHashes.Count; | ||
| int missing = beatmapHashes.Count(hash => beatmapManager.QueryBeatmap(b => b.MD5Hash == hash) == null); |
There was a problem hiding this comment.
So let me get this straight:
.Count() here is LINQ. Meaning that for every beatmap hash in a collection, this is going to perform one beatmap lookup by hash. This happens every time any beatmap in the game is added, modified or removed. And also this is going to simultaneously be queried for every single collection existing in the game when the N subscriptions for N collections fire.
I haven't ran this yet, but let's just say I'm skeptical this will be anywhere near acceptable performance. Benchmarking on a not-small database would be very appreciated here.
Intended to closes #32244
This adds “(n missing)” when beatmaps in a collection are deleted.
All tests pass, style checks clean.