Exclude non-user-playable mods from mod filter in beatmap leaderboard #32949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For easier understanding, substitute "non-user-playable" with "autoplay". The reason that I'm bothering to do this is that if you put autoplay on and turn on the "Selected Mods" filter, the request will actually go through and hit web, and web will obviously return no scores. On song select that's *maybe* fine, even though probably unintended still, but now with the leaderboard state being global this also means gameplay gets impacted. Which also means that if you Ctrl-Enter to start a map in autoplay you're not going to get any gameplay leaderboard scores at all.
peppy
approved these changes
Apr 28, 2025
bdach
deleted the
exclude-non-user-playable-mods-from-leaderboard-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier understanding, substitute "non-user-playable" with "autoplay".
The reason that I'm bothering to do this is that if you put autoplay on and turn on the "Selected Mods" filter, the request will actually go through and hit web, and web will obviously return no scores. On song select that's maybe fine, even though probably unintended still, but now with the leaderboard state being global this also means gameplay gets impacted. Which also means that if you Ctrl-Enter to start a map in autoplay you're not going to get any gameplay leaderboard scores at all.