Skip to content

Fix Ctrl + Enter Autoplay shortcut animation#36801

Open
Xiragi wants to merge 1 commit intoppy:masterfrom
Xiragi:fix-footer-overlap-animation
Open

Fix Ctrl + Enter Autoplay shortcut animation#36801
Xiragi wants to merge 1 commit intoppy:masterfrom
Xiragi:fix-footer-overlap-animation

Conversation

@Xiragi
Copy link
Contributor

@Xiragi Xiragi commented Mar 3, 2026

@LiquidPL
Copy link
Contributor

LiquidPL commented Mar 3, 2026

The reason why the buttons don't animate properly is because upon transition to a new screen they are moved to hiddenButtonsContainer which is just a plain Container, and not a fill flow container, because of which the buttons are no longer doing any relayouts.

Also, button.DisappearToBottom() immediately calls FinishTransforms() which interrupts the resize transform, and causes drawables to additionally jump around.

I guess I'm writing this more because I'm starting to wonder if there is a need to call FinishTransforms() on every appear/disappear, or could we only call that method in some places where it is necessary (ideally not when changing screens), which would possibly solve this issue.

@Xiragi
Copy link
Contributor Author

Xiragi commented Mar 3, 2026

seems worth investigating. didn't feel right to me to be updating the positions manually

foreach (var b in oldButtons)
b.FinishTransforms();

buttonsFlow.UpdateSubTree();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot exist without inline commenting precisely explaining what it's doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants