Add menu item to delete all beatmap sets in filter groups#36841
Add menu item to delete all beatmap sets in filter groups#36841LBlend wants to merge 5 commits intoppy:masterfrom
Conversation
Add an option to delete all beatmapsets in the group in question
Code Quality. Making sure tests pass
Code Quality. Making sure tests pass
| public BeatmapGroupDeleteDialog(GroupDefinition group, IReadOnlyList<BeatmapSetInfo> beatmapSets) | ||
| { | ||
| this.beatmapSets = beatmapSets; | ||
| BodyText = group.Title; |
There was a problem hiding this comment.
This dialog should definitely show a count of how many beatmap sets are to be deleted.
|
I was skeptical that this would be correct for BPM grouping, but it seems we changed that to group by sets therefore it works as expected. Before merging we want to be 100% sure that this option won't appear on a group which could have partial contents of beatmap sets in it (but cause a deletion of the full sets). |
AFAIK this applies to:
This is assuming that we're not handling "edge cases", i.e. maps that have difficulties with different songs, which will have different BPMs, titles, artists, sources etc. I'll look into it! |
Based on our current grouping rules, this is not feasible technically. So I think we're fine. But it needs confirmation/safeties at a code level to ensure we don't shoot ourselves in the foot. |

As requested in #36825, this adds a menu item to delete all beatmap sets in whichever group you right click. It will make it easier to mass delete maps and save some precious storage. Considering the spike in SSD prices recently, I for one would like more options to mass delete maps.
Things that should maybe be addressed, hence why this is a draft: