Extend CheckOffscreenObjects to handle abnormal hitboject coordinates#36916
Open
Hiviexd wants to merge 3 commits intoppy:masterfrom
Open
Extend CheckOffscreenObjects to handle abnormal hitboject coordinates#36916Hiviexd wants to merge 3 commits intoppy:masterfrom
CheckOffscreenObjects to handle abnormal hitboject coordinates#36916Hiviexd wants to merge 3 commits intoppy:masterfrom
Conversation
|
Some issues:
|
Member
Author
Slider bodies are untouched by this PR, they're handled by the offscreen check which has been working as intended for years. Re: tails, will need examples of said ranked maps to verify.
Any example ranked maps I can use to test against this edge case? Agree with excluding stacks from this check.
Will also need example beatmaps for both points. |
|
1~3 are quite common, here are just some random examples:
Please ignore point 4 (they are indeed caused by stacks), sorry. |
any issues caused by big stacks are covered by the offscreen check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #31223