Skip to content

Fix beatmap preview tracks never using API sourced URL #36945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peppy wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2

Add missing file extension

27094d2
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Fix beatmap preview tracks never using API sourced URL #36945

Add missing file extension
27094d2
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Mar 12, 2026 in 1s

30506 passed, 10 failed and 268 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 7627✅ 2❌ 67⚪ 1951s
TestResults-Linux-SingleThread.trx 7626✅ 3❌ 67⚪ 1738s
TestResults-Windows-MultiThreaded.trx 7626✅ 3❌ 67⚪ 3251s
TestResults-Windows-SingleThread.trx 7627✅ 2❌ 67⚪ 2656s

❌ TestResults-Linux-MultiThreaded.trx

7696 tests were completed in 1951s with 7627 passed, 2 failed and 67 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview 2❌ 20s

❌ osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview

❌ TestConstructor
	"load tracks" timed out
❌ TestSongPreview
	"load tracks" timed out

❌ TestResults-Linux-SingleThread.trx

7696 tests were completed in 1738s with 7626 passed, 3 failed and 67 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback 1✅ 1❌ 96s
osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview 2❌ 20s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback

❌ TestAllSamplesStopDuringSeek
	"wait for slider sliding then seek" timed out
✅ TestConstructor

❌ osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview

❌ TestConstructor
	"load tracks" timed out
❌ TestSongPreview
	"load tracks" timed out

❌ TestResults-Windows-MultiThreaded.trx

7696 tests were completed in 3251s with 7626 passed, 3 failed and 67 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview 2❌ 21s
osu.Game.Tests.Visual.Ranking.TestSceneSoloResultsScreen 10✅ 1❌ 16s

❌ osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview

❌ TestConstructor
	"load tracks" timed out
❌ TestSongPreview
	"load tracks" timed out

❌ osu.Game.Tests.Visual.Ranking.TestSceneSoloResultsScreen

✅ TestConstructor
✅ TestLocalLeaderboardWithOfflineScore
✅ TestLocalLeaderboardWithOnlineScore
✅ TestOnlineLeaderboardDeduplication
✅ TestOnlineLeaderboardWithLessThan50Scores
✅ TestOnlineLeaderboardWithLessThan50Scores_ShowingAnotherUserScore
✅ TestOnlineLeaderboardWithLessThan50Scores_UserIsLast
❌ TestOnlineLeaderboardWithLessThan50Scores_UserWasInTop50
	"local score is #16" timed out: Expected: 16
	  But was:  31
	
✅ TestOnlineLeaderboardWithMoreThan50Scores_UserInTop50
✅ TestOnlineLeaderboardWithMoreThan50Scores_UserOutsideOfTop50_BeatOwnBest
✅ TestOnlineLeaderboardWithMoreThan50Scores_UserOutsideOfTop50_DidNotBeatOwnBest

❌ TestResults-Windows-SingleThread.trx

7696 tests were completed in 2656s with 7627 passed, 2 failed and 67 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview 2❌ 20s

❌ osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview

❌ TestConstructor
	"load tracks" timed out
❌ TestSongPreview
	"load tracks" timed out

Annotations

Check failure on line 49 in osu.Game.Tests/Visual/RankedPlay/TestSceneSongPreview.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview ► TestConstructor 

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-SingleThread.trx
Error:
  "load tracks" timed out
Raw output 
"load tracks" timed out
   at osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview.SetUpSteps() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/RankedPlay/TestSceneSongPreview.cs:line 49

Check failure on line 49 in osu.Game.Tests/Visual/RankedPlay/TestSceneSongPreview.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview ► TestSongPreview 

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-SingleThread.trx
Error:
  "load tracks" timed out
Raw output 
"load tracks" timed out
   at osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview.SetUpSteps() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/RankedPlay/TestSceneSongPreview.cs:line 49
   at InvokeStub_TestSceneSongPreview.SetUpSteps(Object, Object, IntPtr*)

Check failure on line 39 in osu.Game.Tests/Visual/Gameplay/TestSceneGameplaySamplePlayback.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback ► TestAllSamplesStopDuringSeek 

Failed test found in:
  TestResults-Linux-SingleThread.trx
Error:
  "wait for slider sliding then seek" timed out
Raw output 
"wait for slider sliding then seek" timed out
   at osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback.TestAllSamplesStopDuringSeek() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/Gameplay/TestSceneGameplaySamplePlayback.cs:line 39
   at InvokeStub_TestSceneGameplaySamplePlayback.TestAllSamplesStopDuringSeek(Object, Object, IntPtr*)

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview ► TestConstructor 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "load tracks" timed out
Raw output 
"load tracks" timed out
   at osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview.SetUpSteps() in D:\a\osu\osu\osu.Game.Tests\Visual\RankedPlay\TestSceneSongPreview.cs:line 49

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview ► TestSongPreview 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "load tracks" timed out
Raw output 
"load tracks" timed out
   at osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview.SetUpSteps() in D:\a\osu\osu\osu.Game.Tests\Visual\RankedPlay\TestSceneSongPreview.cs:line 49
   at InvokeStub_TestSceneSongPreview.SetUpSteps(Object, Object, IntPtr*)

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Ranking.TestSceneSoloResultsScreen ► TestOnlineLeaderboardWithLessThan50Scores_UserWasInTop50 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "local score is #16" timed out: Expected: 16
    But was:  31
Raw output 
"local score is #16" timed out: Expected: 16
  But was:  31

   at osu.Game.Tests.Visual.Ranking.TestSceneSoloResultsScreen.TestOnlineLeaderboardWithLessThan50Scores_UserWasInTop50() in D:\a\osu\osu\osu.Game.Tests\Visual\Ranking\TestSceneSoloResultsScreen.cs:line 222

Check failure on line 0 in TestResults-Windows-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview ► TestConstructor 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  "load tracks" timed out
Raw output 
"load tracks" timed out
   at osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview.SetUpSteps() in D:\a\osu\osu\osu.Game.Tests\Visual\RankedPlay\TestSceneSongPreview.cs:line 49

Check failure on line 0 in TestResults-Windows-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview ► TestSongPreview 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  "load tracks" timed out
Raw output 
"load tracks" timed out
   at osu.Game.Tests.Visual.RankedPlay.TestSceneSongPreview.SetUpSteps() in D:\a\osu\osu\osu.Game.Tests\Visual\RankedPlay\TestSceneSongPreview.cs:line 49
   at InvokeStub_TestSceneSongPreview.SetUpSteps(Object, Object, IntPtr*)
View more details on GitHub Actions