Add localisation support to remaining notifications#36994
Open
diquoks wants to merge 7 commits intoppy:masterfrom
Open
Add localisation support to remaining notifications#36994diquoks wants to merge 7 commits intoppy:masterfrom
diquoks wants to merge 7 commits intoppy:masterfrom
Conversation
diquoks
commented
Mar 17, 2026
Comment on lines
+233
to
+246
|
|
||
| protected virtual LocalisableString DeleteModelsAbortedText => $"No {HumanisedModelName}s found to delete!"; | ||
|
|
||
| protected virtual LocalisableString DeleteModelsStartingText => $"Preparing to delete all {HumanisedModelName}s..."; | ||
|
|
||
| protected virtual LocalisableString DeleteModelsRunningText(int processedCount, int totalCount) => $"Deleting {HumanisedModelName}s ({processedCount} of {totalCount})"; | ||
|
|
||
| protected virtual LocalisableString DeleteModelsCompletedText => $"Deleted all {HumanisedModelName}s!"; | ||
|
|
||
| protected virtual LocalisableString RestoreModelsAbortedText => $"No {HumanisedModelName}s found to restore!"; | ||
|
|
||
| protected virtual LocalisableString RestoreModelsRunningText(int processedCount, int totalCount) => $"Restoring deleted {HumanisedModelName}s ({processedCount} of {totalCount})"; | ||
|
|
||
| protected virtual LocalisableString RestoreModelsCompletedText => $"Restored all deleted {HumanisedModelName}s!"; |
Contributor
Author
There was a problem hiding this comment.
i don't think this is the cleanest way to do it, but i'm not aware of any others
Comment on lines
+665
to
+680
|
|
||
| protected virtual LocalisableString ImportAbortedText => $"No {HumanisedModelName}s were found to import!"; | ||
|
|
||
| protected virtual LocalisableString ImportStartingText => $"{HumanisedModelName.Humanize(LetterCasing.Title)} import is initialising..."; | ||
|
|
||
| protected virtual LocalisableString ImportRunningText(int processedCount, int totalCount) => $"Importing {HumanisedModelName}s ({processedCount} of {totalCount})"; | ||
|
|
||
| protected virtual LocalisableString ImportCompletedText(int totalCount) => $"Imported {totalCount} {HumanisedModelName}s!"; | ||
|
|
||
| protected virtual LocalisableString ImportIncompletedText(int processedCount, int totalCount) => $"Imported {processedCount} of {totalCount} {HumanisedModelName}s!"; | ||
|
|
||
| protected virtual LocalisableString ImportFailedText => $"{HumanisedModelName.Humanize(LetterCasing.Title)} import failed! Check logs for more information."; | ||
|
|
||
| protected virtual LocalisableString ImportPausedText => $"{HumanisedModelName.Humanize(LetterCasing.Title)} import is paused due to gameplay..."; | ||
|
|
||
| protected virtual LocalisableString ImportResumingText => $"{HumanisedModelName.Humanize(LetterCasing.Title)} import is resuming..."; |
Contributor
Author
There was a problem hiding this comment.
i don't think this is the cleanest way to do it, but i'm not aware of any others
same here
Comment on lines
+390
to
+393
| /// <summary> | ||
| /// "({0} of {1})" | ||
| /// </summary> | ||
| public static LocalisableString BackgroundDataStoreProcessorItemsStatus(int processedItems, int totalItems) => new TranslatableString(getKey(@"data_store_processor_items_status"), @"({0} of {1})", processedItems, totalItems); |
Contributor
Author
There was a problem hiding this comment.
decided to take out this string so as not to duplicate the same thing twice
it might be worth editing strings above to something like
"Preparing to do X..." or "X is initialising..."
"Doing X ({0} of {1})"
similar to how it's done in ModelManager & RealmArchiveModelImporter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes can be reviewed commit by commit