Fix replay/spectator scroll text not toggling with Ctrl+H#37027
Open
peppy wants to merge 3 commits intoppy:masterfrom
Open
Fix replay/spectator scroll text not toggling with Ctrl+H#37027peppy wants to merge 3 commits intoppy:masterfrom
peppy wants to merge 3 commits intoppy:masterfrom
Conversation
peppy
force-pushed
the
fix-scrolling-text-under-skin
branch
from
969b694 to
8b5acf0
Compare
bdach
requested changes
Mar 18, 2026
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
- Replay controls are still fully interactable even when they're toggled off.
Screen.Recording.2026-03-18.at.10.34.15.mov
- In multiplayer spectator completely hiding the new replay overlay means that there is no way to know which player is which anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to add toggle but forgot.
This also fixes #37012 via a convoluted refactor of a lot of stuff. The basic overview is:
HUDOverlay. We can display this above everything confidently (i think).ReplayOverlayandReplaySettingsOverlayso the base class can handle the visibility, hotkeys and everything that should be shared with all replay overlay components going forward.Ctrl+His supposed to hide any of these kinds of details, and I'm sure we'll add more in the future.Playerso the new structure would work. Mainly the overlays which add a black layer during fade out.