Switch online play screens to new header#37074
Open
LiquidPL wants to merge 1 commit intoppy:masterfrom
Open
Conversation
Specifically the one used on the daily challenge screen.
LiquidPL
commented
Mar 23, 2026
Comment on lines
+64
to
+77
| protected override void LoadComplete() | ||
| { | ||
| base.LoadComplete(); | ||
|
|
||
| Details.BindValueChanged(updateDetails); | ||
| } | ||
|
|
||
| private void updateDetails(ValueChangedEvent<string> details) | ||
| { | ||
| if (detailsPart != null) | ||
| textFlow.RemovePart(detailsPart); | ||
|
|
||
| detailsPart = textFlow.AddText($" {details.NewValue}", t => t.Colour = colourProvider.Highlight1); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This shouldn't do anything at all on non-online play screens which don't touch the bindable, but I still wonder if it'd be better to move this logic out to an online play specific class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically the one used on the daily challenge screen. Was bugging me that playlists/multi have that old yellow header design used, so I've changed it. Will probably come in handy once the footer/leaderboard changes are in.
Also localized the headers while at it.
Multiplayer:
Playlists:
The only thing I'm wondering about is whether the detail thing (participant count/playlist length) should be using the highlight colour here. The old design had them be yellow, but I feel like the pink on this one stands out too much.