osu!taiko reading difficulty rework#37168
Conversation
| /// The combined star rating of all skills. | ||
| /// </summary> | ||
| [JsonProperty("star_rating_classic", Order = -2)] | ||
| public double StarRatingClassic { get; set; } |
There was a problem hiding this comment.
This can't exist. You will have to wait for the realtime diffcalc for different classic/non-classic SR. For now assume everything is calculated with CL
There was a problem hiding this comment.
would this deploy be a good time to get realtime merged?
There was a problem hiding this comment.
This is not up to us and as far as I know not coming in the roadmap any time soon. Please just take any changes that rely on realtime's existence out and we'll revisit when we can
There was a problem hiding this comment.
unfortunate, i'll see what i can do
There was a problem hiding this comment.
Not trying to be difficult but replacing it with Hidden instead of Classic is not really addressing the problem. I don't think doing this with any mod is particularly a great idea.
There was a problem hiding this comment.
i think this is the best i can do, hidden absolutely needs different consideration on lazer and penalising all reading difficulty would be unfair for its other components that work the same across both clients. the only way to properly address the problem is realtime. i also don't think this way of doing it feels too out of place, we already extract rhythm difficulty as an attribute just to penalise it in performance
There was a problem hiding this comment.
The problem is that these attributes are stored for every single mod combination, so you are going to add a lot of storage overhead on combinations where this attribute will never be used.
3 participants
This change moves all mod bonuses to difficulty out of performance and into reading, as well as adjusting their effects on difficulty based on feedback. Currently being balanced with my rhythm change planned for this deploy at https://pp.huismetbenen.nl/rankings/players/otona-plus-reading, and any balancing changes will be made in a separate PR afterwards
Notably, bonuses/nerfs from the classic mod are moved into diffcalc. Without ppy/osu-queue-score-statistics#274 this is implemented by calculating difficulty both with and without the classic mod, and picking the correct star rating and consistency factor to use in performance. This can be hugely simplified as soon as realtime is merged but for now I think this is the best we can do. I will leave databasing to the maintainers as I'm not 100% sure how to go about it. This also comes with the challenge of displaying the right star rating in each client which I'm also not sure where to start