osu!taiko reading difficulty rework#37168
Open
buyaspacecube wants to merge 15 commits intoppy:pp-devfrom
Open
Conversation
stanriders
requested changes
Apr 1, 2026
This reverts commit 1664c4b.
Member
|
Just for my understanding (as I will need to make code changes to make this happen) - Hidden does not currently affect star rating for osu!taiko, but you expect it to following this change? Any other mods? |
Member
Author
|
yes, both hidden and flashlight will now affect star rating |
Member
|
Will FL always affect SR? Or only when combined with HD? |
Member
Author
|
yes it can affect star rating individually. in case it matters as well, ez can now increase star rating rather than just decreasing it |
Member
Author
|
@Lawtrohux i would apply the stamina and mono streak changes to #37594 instead of here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves all mod bonuses to difficulty out of performance and into reading, as well as adjusting their effects on difficulty based on feedback. Currently being balanced with my rhythm change planned for this deploy at https://pp.huismetbenen.nl/rankings/players/otona-plus-reading, and any balancing changes will be made in a separate PR afterwards
The older and intended version of this includes diffcalc changes across stable and lazer, but until ppy/osu-queue-score-statistics#274 these have been replaced with an estimated nerf to lazer reading difficulty in performance