Skip to content

Make Ok adjustment formula more stable #37263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Givikap120 wants to merge 3 commits into
base: pp-dev
Choose a base branch
from
+1 −1
Open

Make Ok adjustment formula more stable #37263

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a65395
Make Ok adjustment formula more stable
Givikap120 Apr 11, 2026
e4d5791
Merge branch 'pp-dev' into fix-ok-adjustment-formula
tsunyoku Apr 14, 2026
7d67b01
Merge branch 'pp-dev' into fix-ok-adjustment-formula
tsunyoku Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ private double calculateEstimatedSliderBreaks(double topWeightedSliderFactor, Os
double estimatedSliderBreaks = Math.Min(countOk, effectiveMissCount * topWeightedSliderFactor);

// Scores with more Oks are more likely to have slider breaks.
double okAdjustment = ((countOk - estimatedSliderBreaks) + 0.5) / countOk;
double okAdjustment = (countOk - estimatedSliderBreaks + 4) / (countOk + 4);

// There is a low probability of extra slider breaks on effective miss counts close to 1, as score based calculations are good at indicating if only a single break occurred.
estimatedSliderBreaks *= DifficultyCalculationUtils.Smoothstep(effectiveMissCount, 1, 2);
Expand Down
Loading