Added Dimming when Multiple Overlays are Opened#37273
Open
nathanc7278 wants to merge 3 commits intoppy:masterfrom
Open
Added Dimming when Multiple Overlays are Opened#37273nathanc7278 wants to merge 3 commits intoppy:masterfrom
nathanc7278 wants to merge 3 commits intoppy:masterfrom
Conversation
Member
|
The code quality here isn't break, and feels like it could fall over at any point. |
Author
|
I've updated my implementation to not hard-code the overlays that are affected. The dimming logic now checks if there are any visible dim_fix.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36613
Added logic that dims the
overlayContent(wikis, play area, skin editor,...), theleftFloatingOverlayContent(settings area), and the top toolbar when adialogOverlayor confirm button appears on the screen. Additionally created anupdateRightFloatingOverlayDimfunction that checks if thenotificationbar,loginbox, andnow playingbox is open. Dimming priority for right floating overlays:now playing>login>notification>overlayContent.Before:
current_release.mp4
After:
fix_dim.mp4