Skip to content

Added Dimming when Multiple Overlays are Opened#37273

Open
nathanc7278 wants to merge 3 commits intoppy:masterfrom
nathanc7278:dim-multiple-overlays
Open

Added Dimming when Multiple Overlays are Opened#37273
nathanc7278 wants to merge 3 commits intoppy:masterfrom
nathanc7278:dim-multiple-overlays

Conversation

@nathanc7278
Copy link
Copy Markdown

Fixes #36613

Added logic that dims the overlayContent (wikis, play area, skin editor,...), the leftFloatingOverlayContent (settings area), and the top toolbar when a dialogOverlay or confirm button appears on the screen. Additionally created an updateRightFloatingOverlayDim function that checks if the notification bar, login box, and now playing box is open. Dimming priority for right floating overlays: now playing > login > notification > overlayContent.

Before:

current_release.mp4

After:

fix_dim.mp4

@peppy
Copy link
Copy Markdown
Member

peppy commented Apr 12, 2026

The code quality here isn't break, and feels like it could fall over at any point.

Comment thread osu.Game/OsuGame.cs Fixed
Comment thread osu.Game/OsuGame.cs Fixed
@nathanc7278
Copy link
Copy Markdown
Author

nathanc7278 commented Apr 12, 2026

I've updated my implementation to not hard-code the overlays that are affected. The dimming logic now checks if there are any visible OverlayContainers above the current container to determine if it should dim. The dialog dimming is essentially the same, except that I use the parent container: OverlayOffsetContainer which contains the overlayContent, leftFloatingOverlayContent, and now the rightOverlayContent. I kept it this way because it would not make sense to allow the user to click other buttons during a dialog/confirm prompt. Does this approach match what you had in mind?

dim_fix.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attentions doesn't dim the entire screen behind it in certain situations

3 participants